From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCDEECAAA1 for ; Tue, 30 Aug 2022 16:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbiH3Qqt convert rfc822-to-8bit (ORCPT ); Tue, 30 Aug 2022 12:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbiH3Qqq (ORCPT ); Tue, 30 Aug 2022 12:46:46 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45E05B2CF2 for ; Tue, 30 Aug 2022 09:46:45 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4Nf-0002qT-EK; Tue, 30 Aug 2022 18:46:27 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oT4Nd-002uAy-VN; Tue, 30 Aug 2022 18:46:25 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1oT4Nd-000CJM-4G; Tue, 30 Aug 2022 18:46:25 +0200 Message-ID: <569a5d63af850d4180546c2c25220cbb988846eb.camel@pengutronix.de> Subject: Re: [PATCH v5 4/7] reset: imx7: Fix the iMX8MP PCIe PHY PERST support From: Philipp Zabel To: Richard Zhu , l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org, shawnguo@kernel.org, vkoul@kernel.org, alexander.stein@ew.tq-group.com, marex@denx.de, richard.leitner@linux.dev Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Date: Tue, 30 Aug 2022 18:46:25 +0200 In-Reply-To: <1661845564-11373-5-git-send-email-hongxing.zhu@nxp.com> References: <1661845564-11373-1-git-send-email-hongxing.zhu@nxp.com> <1661845564-11373-5-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Di, 2022-08-30 at 15:46 +0800, Richard Zhu wrote: > On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST bit(BIT3) > of SRC_PCIEPHY_RCR is 1b'1. > But i.MX8MP has one inversed default value 1b'0 of PERST bit. > > And the PERST bit should be kept 1b'1 after power and clocks are stable. > So fix the i.MX8MP PCIe PHY PERST support here. > > Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC") > Signed-off-by: Richard Zhu > Reviewed-by: Philipp Zabel > Tested-by: Marek Vasut > Tested-by: Richard Leitner > Tested-by: Alexander Stein I've applied this patch to the reset/fixes branch. regards Philipp