devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Coiby Xu <coxu@redhat.com>, Michael Ellerman <mpe@ellerman.id.au>
Cc: kexec@lists.infradead.org, devicetree@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, nayna@linux.ibm.com,
	nasastry@in.ibm.com, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH v8 0/4] tpm: Preserve TPM measurement log across kexec (ppc64)
Date: Fri, 11 Nov 2022 07:12:05 -0500	[thread overview]
Message-ID: <569c30f7-5dda-4ce2-e2c9-ce4041a74c8e@linux.ibm.com> (raw)
In-Reply-To: <20221111022143.xvpi3pfwwrw4qda2@Rk>



On 11/10/22 21:21, Coiby Xu wrote:
> Hi Michael,
> 
> Could the PowerPC tree take this patch set which resolves a
> PowerVM/KVM-specific issue?

Michael has (shown me) an alternative approach that protects the already allocated memory to carry it across the kexec. This seems like a good and potentially better alternative, also from the perspective of the changes need, which is a lot less , and it's already used for other stuff as well.

    Stefan

> 
> On Thu, Sep 01, 2022 at 05:46:06PM -0400, Stefan Berger wrote:
>> The of-tree subsystem does not currently preserve the IBM vTPM 1.2 and
>> vTPM 2.0 measurement logs across a kexec on PowerVM and PowerKVM. This
>> series fixes this for the kexec_file_load() syscall using the flattened
>> device tree (fdt) to carry the TPM measurement log's buffer across kexec.
>>
>>   Stefan
>>
>> v8:
>> - Added Jarkko's, Coiby's, and Rob's tags
>> - Rebase on v6.0-rc3 that absorbed 2 already upstreamed patches
>>
>> v7:
>> - Added Nageswara's Tested-by tags
>> - Added back original comment to inline function and removed Jarkko's R-b tag
>>
>> v6:
>> - Add __init to get_kexec_buffer as suggested by Jonathan
>> - Fixed issue detected by kernel test robot
>>
>> v5:
>> - Rebased on 1 more patch that would otherwise create merge conflicts
>>
>> v4:
>> - Rebased on 2 patches that would otherwise create merge conflicts;
>>   posting these patches in this series with several tags removed so
>>   krobot can test the series already
>> - Changes to individual patches documented in patch descripitons
>>
>> v3:
>> - Moved TPM Open Firmware related function to drivers/char/tpm/eventlog/tpm_of.c
>>
>> v2:
>> - rearranged patches
>> - fixed compilation issues for x86
>>
>> Palmer Dabbelt (1):
>>  drivers: of: kexec ima: Support 32-bit platforms
>>
>> Stefan Berger (3):
>>  tpm: of: Make of-tree specific function commonly available
>>  of: kexec: Refactor IMA buffer related functions to make them reusable
>>  tpm/kexec: Duplicate TPM measurement log in of-tree for kexec
>>
>> drivers/char/tpm/eventlog/of.c |  31 +--
>> drivers/of/kexec.c             | 336 ++++++++++++++++++++++++++++-----
>> include/linux/kexec.h          |   6 +
>> include/linux/of.h             |   9 +-
>> include/linux/tpm.h            |  36 ++++
>> kernel/kexec_file.c            |   6 +
>> 6 files changed, 346 insertions(+), 78 deletions(-)
>>
>>
>> base-commit: b90cb1053190353cc30f0fef0ef1f378ccc063c5
>> -- 
>> 2.35.1
>>
> 

      reply	other threads:[~2022-11-11 12:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 21:46 [PATCH v8 0/4] tpm: Preserve TPM measurement log across kexec (ppc64) Stefan Berger
2022-09-01 21:46 ` [PATCH v8 1/4] drivers: of: kexec ima: Support 32-bit platforms Stefan Berger
2022-09-01 21:46 ` [PATCH v8 2/4] tpm: of: Make of-tree specific function commonly available Stefan Berger
2022-09-02  3:20   ` Jarkko Sakkinen
2022-09-01 21:46 ` [PATCH v8 3/4] of: kexec: Refactor IMA buffer related functions to make them reusable Stefan Berger
2022-09-01 21:46 ` [PATCH v8 4/4] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec Stefan Berger
2022-09-12 13:00 ` [PATCH v8 0/4] tpm: Preserve TPM measurement log across kexec (ppc64) Stefan Berger
2022-09-14 18:01   ` Rob Herring
2022-09-14 19:46     ` Stefan Berger
2022-09-14 20:18       ` Rob Herring
2022-09-15  1:20     ` Baoquan He
2022-11-11  2:21 ` Coiby Xu
2022-11-11 12:12   ` Stefan Berger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569c30f7-5dda-4ce2-e2c9-ce4041a74c8e@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=bhe@redhat.com \
    --cc=coxu@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nasastry@in.ibm.com \
    --cc=nayna@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).