From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Olof Johansson <olof@lixom.net>
Cc: Aaro Koskinen <aaro.koskinen@nokia.com>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [BISECTED] v4.5-rc1 phylib regression
Date: Tue, 26 Jan 2016 15:54:13 -0800 [thread overview]
Message-ID: <56A80725.1070808@gmail.com> (raw)
In-Reply-To: <20160126220924.GK27473@lunn.ch>
On 26/01/16 14:09, Andrew Lunn wrote:
>>> Nope, not an option. Only a small number of DTB actually use c22 or
>>> c45. The majority of devices have no compatible at all. Why should
>>> they, the binding documentation says it is optional!
>>
>> So one thing that can be done is to just have a whitelist in the
>> driver that we add the known phy compatibles to, with a nice comment
>> above that this should only be for legacy device trees.
>
> So you mean drivers/of/of_mdio.c:of_mdiobus_child_is_phy()
> has a white list like:
>
> "brcm,40nm-ephy"
> "marvell,88E1111",
> "marvell,88e1116",
> "marvell,88e1118",
> "marvell,88e1149r",
> "marvell,88e1310",
> "marvell,88E1510",
> "marvell,88E1514",
> "moxa,moxart-rtl8201cp",
>
> Yes, that would work.
>
> We should also update the binding documentation to limit what is legal
> in the compatible string.
Agreed, and while at it, take the opportunity to make the compatible
string clause 22/45 mandatory properties so we do not multiply the
whitelist.
Thanks!
--
Florian
next prev parent reply other threads:[~2016-01-26 23:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160125154520.GI22974@ak-desktop.emea.nsn-net.net>
[not found] ` <20160126044624.GH3880@lunn.ch>
[not found] ` <20160126121435.GK22974@ak-desktop.emea.nsn-net.net>
[not found] ` <20160126133417.GI3880@lunn.ch>
[not found] ` <CAOesGMgaB8R+7jGyLNgQ-M+2nVRhOsEp7LUbiApEEw+dscfL0w@mail.gmail.com>
[not found] ` <20160126175353.GG27473@lunn.ch>
[not found] ` <CAOesGMhYU4NOeGRJoF4bcELCFfSsvBVp2du7ZgVjC3QuCv637w@mail.gmail.com>
2016-01-26 18:14 ` [BISECTED] v4.5-rc1 phylib regression Olof Johansson
[not found] ` <CAOesGMi+ymn_FdDfgTjwgyO-MsEJNGBDU9ayRJvGkjJ7T_ExfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-26 20:46 ` Florian Fainelli
[not found] ` <56A7DB27.6080203-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-26 21:36 ` Andrew Lunn
2016-01-26 21:48 ` Olof Johansson
2016-01-26 22:09 ` Andrew Lunn
2016-01-26 23:54 ` Florian Fainelli [this message]
[not found] ` <56A80725.1070808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-27 0:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A80725.1070808@gmail.com \
--to=f.fainelli@gmail.com \
--cc=aaro.koskinen@nokia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).