* [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON
@ 2016-01-09 6:59 Bhuvanchandra DV
2016-01-27 18:23 ` Bhuvanchandra DV
[not found] ` <1452322793-26020-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
0 siblings, 2 replies; 5+ messages in thread
From: Bhuvanchandra DV @ 2016-01-09 6:59 UTC (permalink / raw)
To: shawnguo
Cc: devicetree, Bhuvanchandra DV, linux-kernel, stefan, kernel,
linux-arm-kernel
Use pwm-backlight driver 'enable-gpios' property for backlight on/off
control.
Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
arch/arm/boot/dts/vf-colibri.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
index e5949b9..1c0da05 100644
--- a/arch/arm/boot/dts/vf-colibri.dtsi
+++ b/arch/arm/boot/dts/vf-colibri.dtsi
@@ -10,7 +10,10 @@
/ {
bl: backlight {
compatible = "pwm-backlight";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_gpio_bl_on>;
pwms = <&pwm0 0 5000000 0>;
+ enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
status = "disabled";
};
};
@@ -169,6 +172,12 @@
>;
};
+ pinctrl_gpio_bl_on: gpio_bl_on {
+ fsl,pins = <
+ VF610_PAD_PTC0__GPIO_45 0x22ef
+ >;
+ };
+
pinctrl_i2c0: i2c0grp {
fsl,pins = <
VF610_PAD_PTB14__I2C0_SCL 0x37ff
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON
2016-01-09 6:59 [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON Bhuvanchandra DV
@ 2016-01-27 18:23 ` Bhuvanchandra DV
[not found] ` <1452322793-26020-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
1 sibling, 0 replies; 5+ messages in thread
From: Bhuvanchandra DV @ 2016-01-27 18:23 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, devicetree, kernel, stefan, linux-kernel
Ping!
On 01/09/2016 12:29 PM, Bhuvanchandra DV wrote:
> Use pwm-backlight driver 'enable-gpios' property for backlight on/off
> control.
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..1c0da05 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -10,7 +10,10 @@
> / {
> bl: backlight {
> compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> pwms = <&pwm0 0 5000000 0>;
> + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> status = "disabled";
> };
> };
> @@ -169,6 +172,12 @@
> >;
> };
>
> + pinctrl_gpio_bl_on: gpio_bl_on {
> + fsl,pins = <
> + VF610_PAD_PTC0__GPIO_45 0x22ef
> + >;
> + };
> +
> pinctrl_i2c0: i2c0grp {
> fsl,pins = <
> VF610_PAD_PTB14__I2C0_SCL 0x37ff
>
--
Best regards,
Bhuvan
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <1452322793-26020-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON
[not found] ` <1452322793-26020-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
@ 2016-01-28 8:39 ` Shawn Guo
2016-01-28 22:28 ` Stefan Agner
2016-02-01 11:19 ` Shawn Guo
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2016-01-28 8:39 UTC (permalink / raw)
To: Bhuvanchandra DV
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, stefan-XLVq0VzYD2Y,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Sat, Jan 09, 2016 at 12:29:53PM +0530, Bhuvanchandra DV wrote:
> Use pwm-backlight driver 'enable-gpios' property for backlight on/off
> control.
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..1c0da05 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -10,7 +10,10 @@
> / {
> bl: backlight {
> compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> pwms = <&pwm0 0 5000000 0>;
> + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> status = "disabled";
> };
> };
> @@ -169,6 +172,12 @@
> >;
> };
>
> + pinctrl_gpio_bl_on: gpio_bl_on {
> + fsl,pins = <
> + VF610_PAD_PTC0__GPIO_45 0x22ef
> + >;
> + };
> +
@Stefan,
Do we need this? My understanding is that on Vybrid, when gpio is
requested, the pinctrl will set it up automatically.
Shawn
> pinctrl_i2c0: i2c0grp {
> fsl,pins = <
> VF610_PAD_PTB14__I2C0_SCL 0x37ff
> --
> 2.7.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON
2016-01-28 8:39 ` Shawn Guo
@ 2016-01-28 22:28 ` Stefan Agner
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Agner @ 2016-01-28 22:28 UTC (permalink / raw)
To: Shawn Guo
Cc: Bhuvanchandra DV, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 2016-01-28 00:39, Shawn Guo wrote:
> On Sat, Jan 09, 2016 at 12:29:53PM +0530, Bhuvanchandra DV wrote:
>> Use pwm-backlight driver 'enable-gpios' property for backlight on/off
>> control.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/vf-colibri.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
>> index e5949b9..1c0da05 100644
>> --- a/arch/arm/boot/dts/vf-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
>> @@ -10,7 +10,10 @@
>> / {
>> bl: backlight {
>> compatible = "pwm-backlight";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
>> pwms = <&pwm0 0 5000000 0>;
>> + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
>> status = "disabled";
>> };
>> };
>> @@ -169,6 +172,12 @@
>> >;
>> };
>>
>> + pinctrl_gpio_bl_on: gpio_bl_on {
>> + fsl,pins = <
>> + VF610_PAD_PTC0__GPIO_45 0x22ef
>> + >;
>> + };
>> +
>
> @Stefan,
>
> Do we need this? My understanding is that on Vybrid, when gpio is
> requested, the pinctrl will set it up automatically.
Yes this is required. The GPIO driver asks the pinctrl driver to enable
the GPIO, and the pinctrl driver requires a "valid" pinmux configuration
to be able to find the IOMUXC register at all.
Acked-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON
[not found] ` <1452322793-26020-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2016-01-28 8:39 ` Shawn Guo
@ 2016-02-01 11:19 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2016-02-01 11:19 UTC (permalink / raw)
To: Bhuvanchandra DV
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, stefan-XLVq0VzYD2Y,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Sat, Jan 09, 2016 at 12:29:53PM +0530, Bhuvanchandra DV wrote:
> Use pwm-backlight driver 'enable-gpios' property for backlight on/off
> control.
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-01 11:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-09 6:59 [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON Bhuvanchandra DV
2016-01-27 18:23 ` Bhuvanchandra DV
[not found] ` <1452322793-26020-1-git-send-email-bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2016-01-28 8:39 ` Shawn Guo
2016-01-28 22:28 ` Stefan Agner
2016-02-01 11:19 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).