From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: Rob Herring <robh@kernel.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
"Andrew F. Davis" <afd@ti.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v5 2/2] gpio: sn65hvs885: Add DT binding documentation
Date: Fri, 29 Jan 2016 07:24:01 +0100 [thread overview]
Message-ID: <56AB0581.6010603@prevas.dk> (raw)
In-Reply-To: <20160129024335.GA5772@rob-hp-laptop>
On 2016-01-29 03:43, Rob Herring wrote:
> On Tue, Jan 26, 2016 at 08:32:46AM +0100, Sean Nyekjaer wrote:
>> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
>> ---
>> Changes since v4:
>> - Added description, required properties
>> - Tested and added support for gpio polarity
>> - Added vendor prefix to compatible flags
>>
>> Changes since v3:
>> - Added gpio-controller and gpio cells flags
>>
>> .../devicetree/bindings/gpio/gpio-sn65hvs885.txt | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
> This looks fine, but I just realized this is the same thing as this[1].
> Please coordinate these bindings.
>
> Rob
>
> [1] https://lkml.org/lkml/2016/1/25/781
I'll just leave this and comment on the other patch :-)
/Sean
>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
>> new file mode 100644
>> index 0000000..c9b3592
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
>> @@ -0,0 +1,20 @@
>> +* TI SN65HVS885 digital-input serializer
>> +
>> +Required properties:
>> +- compatible : Should be "ti,sn65hvs885"
>> +- reg : chip select number
>> +- gpio-controller : Marks the device node as a gpio controller.
>> +- #gpio-cells : Should be two. The first cell is the pin number and
>> + the second cell is used to specify the gpio polarity:
>> + 0 = active high
>> + 1 = active low
>> +
>> +Example:
>> +sn65hvs885@3 {
>> + compatible = "ti,sn65hvs885";
>> + spi-max-frequency = <10000000>;
>> + latch-gpio = <&gpio4 1 GPIO_ACTIVE_HIGH>;
>> + reg = <0>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +};
>> --
>> 2.7.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-01-29 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 7:32 [PATCH v5 1/2] gpio: add TI SN65HVS885 spi industrial input serializer driver Sean Nyekjaer
2016-01-26 7:32 ` [PATCH v5 2/2] gpio: sn65hvs885: Add DT binding documentation Sean Nyekjaer
2016-01-29 2:43 ` Rob Herring
2016-01-29 6:24 ` Sean Nyekjær [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB0581.6010603@prevas.dk \
--to=sean.nyekjaer@prevas.dk \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).