From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"horms@verge.net.au" <horms@verge.net.au>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: porter: add MAX3355 support
Date: Fri, 29 Jan 2016 23:28:25 +0300 [thread overview]
Message-ID: <56ABCB69.1070800@cogentembedded.com> (raw)
In-Reply-To: <SG2PR06MB0919D09C1146EAC0681EE109D8DA0@SG2PR06MB0919.apcprd06.prod.outlook.com>
Hello.
On 01/28/2016 08:49 AM, Yoshihiro Shimoda wrote:
>> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei
>> Shtylyov
>> Sent: Wednesday, January 27, 2016 7:14 AM
>>
>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings
>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we
>> can add MAX3355 device node to the Porter device tree and properly refer
>> to it from the USBHS node instead of using "renesas,enable-gpio" property
>> which only allowed checking the USB ID pin at the driver probe time; now
>> this pin's state can be monitored dynamically!
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened
> even if I connected/disconnected a usb convert cable (usb micro-ab to A).
> Remarks: I confirmed that the usb convert cable worked correctly on other board.
I guess I have the same cable and IRQs do happen for me when I connect and
disconnect it (as it should be).
> Do I need other settings for this?
No evident answer to that, your logs show that MAX3355 driver was enabled...
> root@192:~# cat /proc/interrupts | grep usb
> 108: 0 GIC-0 139 Level e6590000.usb
> 118: 1 GIC-0 140 Level ehci_hcd:usb1, ohci_hcd:usb3
> 119: 0 GIC-0 145 Level ehci_hcd:usb2, ohci_hcd:usb4
> 308: 0 e6055000.gpio 31 Edge usb-otg
> root@192:~#
> root@192:~# cat /proc/interrupts | grep usb
> 108: 0 GIC-0 139 Level e6590000.usb
> 118: 1 GIC-0 140 Level ehci_hcd:usb1, ohci_hcd:usb3
> 119: 0 GIC-0 145 Level ehci_hcd:usb2, ohci_hcd:usb4
> 308: 0 e6055000.gpio 31 Edge usb-otg
> root@192:~#
> root@192:~# cd /sys/class/extcon/extcon0
> root@192:/sys/class/extcon/extcon0# cat state
> USB=1
> USB-HOST=0
I guess these states doesn't change even if you insert your cable?
They also do change for me.
> Best regards,
> Yoshihiro Shimoda
MBR, Sergei
next prev parent reply other threads:[~2016-01-29 20:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 19:53 [PATCH v4 0/2] Add HS-USB device tree support for R8A7790/Lager board Sergei Shtylyov
2014-10-08 19:54 ` [PATCH v4 1/2] ARM: shmobile: r8a7790: add HS-USB device node Sergei Shtylyov
[not found] ` <1674850.BZpGW9kEud-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2014-10-08 19:55 ` [PATCH v4 2/2] ARM: shmobile: lager: enable HS-USB Sergei Shtylyov
2014-10-24 5:09 ` [PATCH v4 0/2] Add HS-USB device tree support for R8A7790/Lager board Simon Horman
2014-10-24 5:22 ` Yoshihiro Shimoda
2015-09-16 23:53 ` [PATCH] ARM: shmobile: r8a7794: add HS-USB DT support Sergei Shtylyov
2015-10-05 3:02 ` Simon Horman
2015-10-14 19:35 ` [PATCH] ARM: shmobile: porter: " Sergei Shtylyov
2015-10-15 0:18 ` Simon Horman
2015-10-15 10:27 ` Sergei Shtylyov
2015-10-27 21:03 ` [PATCH] ARM: shmobile: porter: add CAN0 " Sergei Shtylyov
2015-10-27 22:41 ` Simon Horman
2015-10-27 22:56 ` Sergei Shtylyov
2015-12-24 22:45 ` [PATCH] ARM: shmobile: porter: add DU " Sergei Shtylyov
2015-12-28 5:29 ` Simon Horman
2015-12-28 14:35 ` Sergei Shtylyov
2015-12-28 21:43 ` Simon Horman
2016-01-12 23:06 ` [PATCH] ARM: shmobile: silk: " Sergei Shtylyov
2016-01-18 1:41 ` Simon Horman
2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov
2016-01-25 0:35 ` Kuninori Morimoto
2016-01-26 0:43 ` Simon Horman
2016-01-26 14:31 ` Sergei Shtylyov
2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov
2016-01-28 5:49 ` Yoshihiro Shimoda
2016-01-29 20:28 ` Sergei Shtylyov [this message]
2016-01-29 20:49 ` Sergei Shtylyov
2016-02-01 11:17 ` Yoshihiro Shimoda
2016-02-01 17:54 ` Sergei Shtylyov
2016-02-01 19:00 ` Sergei Shtylyov
2016-02-15 1:45 ` Simon Horman
2016-02-15 10:59 ` Sergei Shtylyov
2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov
2016-02-15 4:56 ` Kuninori Morimoto
2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov
2016-02-15 4:50 ` Kuninori Morimoto
2016-02-15 21:55 ` Simon Horman
2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov
2016-02-26 19:43 ` Sergei Shtylyov
2016-03-02 0:47 ` Simon Horman
2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov
2016-06-17 20:53 ` Sergei Shtylyov
2016-06-20 8:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ABCB69.1070800@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).