From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH v2 1/3] Input: rotary-encoder - make use of devm_* to simplify .probe and .remove Date: Tue, 2 Feb 2016 14:15:28 +0100 Message-ID: <56B0ABF0.8010904@zonque.org> References: <1454408678-6011-1-git-send-email-u.kleine-koenig@pengutronix.de> <1454408678-6011-2-git-send-email-u.kleine-koenig@pengutronix.de> <56B09968.9050705@zonque.org> <20160202130022.GX13664@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160202130022.GX13664@pengutronix.de> Sender: linux-input-owner@vger.kernel.org To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: Ezequiel Garcia , Dmitry Torokhov , Sylvain Rochet , Johan Hovold , Haojian Zhuang , Robert Jarzmik , devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org List-Id: devicetree@vger.kernel.org On 02/02/2016 02:00 PM, Uwe Kleine-K=C3=B6nig wrote: > On Tue, Feb 02, 2016 at 12:56:24PM +0100, Daniel Mack wrote: >> On 02/02/2016 11:24 AM, Uwe Kleine-K=C3=B6nig wrote: >>> For all operations called in .probe there are devm_* variants. >>> (input_register_device is clever enough to be devm aware on its own= =2E) >>> This allows to get rid of the error unwind code paths in .probe and= the >>> complete .remove function. >> >> While at it, could you also convert this over to the gpiod_* API? >=20 > This is done in patch 3. Ah, right. Missed that detail, sorry. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html