From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 1/2] iio: ad5755: add support for dt bindings Date: Tue, 2 Feb 2016 16:33:00 +0100 Message-ID: <56B0CC2C.6020809@metafoo.de> References: <1454416574-6645-1-git-send-email-sean.nyekjaer@prevas.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1454416574-6645-1-git-send-email-sean.nyekjaer-rjjw5hvvQKZaa/9Udqfwiw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sean Nyekjaer , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 02/02/2016 01:36 PM, Sean Nyekjaer wrote: > Still missing a way to provide default modes and settings > for the driver from dt, but I see this as a start. > > Signed-off-by: Sean Nyekjaer Hi, Thanks for the patch. > --- > drivers/iio/dac/ad5755.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c > index bfb350a..e1b6e78 100644 > --- a/drivers/iio/dac/ad5755.c > +++ b/drivers/iio/dac/ad5755.c > @@ -607,6 +607,16 @@ static const struct spi_device_id ad5755_id[] = { > }; > MODULE_DEVICE_TABLE(spi, ad5755_id); > > +static const struct of_device_id ad5755_of_match[] = { > + { .compatible = "adi,ad5755" }, > + { .compatible = "adi,ad5755-1" }, > + { .compatible = "adi,ad5757" }, > + { .compatible = "adi,ad5735" }, > + { .compatible = "adi,ad5737" }, This needs to set the ID for the device type, so that the driver gets instantiated for the correct devicetype. And in the probe function check if the driver was probed via DT (by checking spi->dev.of_node) and if it does get the ID from the of_device_id rather the spi_device_id. > + { } > +}; > +MODULE_DEVICE_TABLE(of, ad5755_of_match); > + > static struct spi_driver ad5755_driver = { > .driver = { > .name = "ad5755", >