From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support Date: Wed, 3 Feb 2016 12:45:09 -0600 Message-ID: <56B24AB5.3070001@codeaurora.org> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> <56B24642.8090105@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fu Wei Cc: Rob Herring , =?UTF-8?Q?Pawe=c5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Guenter Roeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Dave Young , Pratyush Anand , G Gregory , Al List-Id: devicetree@vger.kernel.org Fu Wei wrote: > As you know I have made the pre-timeout support patch, If people like > it, i am happy to go on upstream it separately. > > If we want to use pre-timeout here, user only can use get_pretimeout > and disable panic by setting pretimeout to 0 > but user can not really set pretimeout, because "pre-timeout == > timeout / 2 (always)". > if user want to change pretimeout, he/she has to set_time instead. Ok, I think patches 4 and 5 should be combined, and I think the Kconfig entry should be removed and just use panic_enabled.