From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Date: Thu, 4 Feb 2016 08:46:49 -0800 Message-ID: <56B38079.10607@roeck-us.net> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-5-git-send-email-fu.wei@linaro.org> <20160204163101.GH17257@arm.com> <56B37E52.300@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56B37E52.300@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Timur Tabi , Will Deacon , fu.wei@linaro.org Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, wim@iguana.be, corbet@lwn.net, catalin.marinas@arm.com, Suravee.Suthikulpanit@amd.com, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, dyoung@redhat.com, panand@redhat.com, graeme.gregory@linaro.org, al.stone@linaro.org, hanjun.guo@linaro.org, jcm@redhat.com, arnd@arndb.de, leo.duran@amd.com, sudeep.holla@arm.com List-Id: devicetree@vger.kernel.org On 02/04/2016 08:37 AM, Timur Tabi wrote: > Will Deacon wrote: >>> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >>> >+{ >>> >+ struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >>> >+ >>> >+ /* >>> >+ * Writing WRR for an explicit watchdog refresh. >>> >+ * You can write anyting(like 0xc0ffee). >>> >+ */ >>> >+ writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR); >>> >+ >>> >+ return 0; >>> >+} >> You might get in trouble for that. 0xd09f00d is probably less poisonous. >> >> http://www.petpoisonhelpline.com/poison/caffeine/ > > Any reason why we can't just keep it simple and write 0? +1 Guenter