devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Andy Gross <andy.gross@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: apq8016-sbc: add usb support
Date: Fri, 5 Feb 2016 11:54:19 -0800	[thread overview]
Message-ID: <56B4FDEB.2080202@codeaurora.org> (raw)
In-Reply-To: <1454698880-13973-1-git-send-email-srinivas.kandagatla@linaro.org>

On 02/05/2016 11:01 AM, Srinivas Kandagatla wrote:
> +
> +		usb2513 {
> +			compatible = "smsc,usb3503";
> +			reset-gpios = <&pm8916_gpios 3 GPIO_ACTIVE_LOW>;
> +			initial-mode = <1>;
> +		};
> +
> +		usb_id: usb-id {
> +			interrupt-parent = <&msmgpio>;
> +			compatible = "linux,extcon-usb-gpio";
> +			id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&usb_id_default>;
> +		};

These are not on the SoC bus. Please move them to root.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-02-05 19:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 19:00 [PATCH 0/6] arm64: dts: apq8016 dt patches Srinivas Kandagatla
2016-02-05 19:00 ` [PATCH 1/6] arm64: dts: qcom: add manual pullup setting to otg Srinivas Kandagatla
     [not found] ` <1454698819-13885-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-05 19:01   ` [PATCH 2/6] arm64: dts: qcom: apq8016-sbc: add usb support Srinivas Kandagatla
2016-02-05 19:54     ` Stephen Boyd [this message]
2016-02-05 19:01   ` [PATCH 6/6] arm64: dts: qcom: fix usb digital voltage levels Srinivas Kandagatla
2016-02-05 19:01 ` [PATCH 3/6] arm64: dts: qcom: add audio pinctrls Srinivas Kandagatla
2016-02-05 19:01 ` [PATCH 4/6] arm64: dts: qcom: add lpass node Srinivas Kandagatla
2016-02-05 19:55   ` Stephen Boyd
2016-02-05 19:01 ` [PATCH 5/6] arm64: dts: qcom: apq8016-sbc: enable lpass on DB410c Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B4FDEB.2080202@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).