From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: horms@verge.net.au, linux-renesas-soc@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, magnus.damm@gmail.com,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: dts: r8a7794 add sound support
Date: Tue, 9 Feb 2016 13:52:09 +0300 [thread overview]
Message-ID: <56B9C4D9.6020808@cogentembedded.com> (raw)
In-Reply-To: <87mvraoikj.wl%kuninori.morimoto.gx@renesas.com>
On 2/9/2016 3:08 AM, Kuninori Morimoto wrote:
>> Define the generic R8A7794 part of the sound device node.
>> This sound device is a complex one and comprises the Audio Clock Generator
>> (ADG), Sampling Rate Converter Unit (SCU), Serial Sound Interface [Unit]
>> (SSI[U]), and Audio DMAC-Peripheral-Peripheral.
>> It is up to the board file to enable the device.
>>
>> This patch is based on the R8A7791 sound work by Kuninori Morimoto.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> (snip)
>> + clocks = <&mstp10_clks R8A7794_CLK_SSI_ALL>,
>> + <&mstp10_clks R8A7794_CLK_SSI9>,
>> + <&mstp10_clks R8A7794_CLK_SSI8>,
>> + <&mstp10_clks R8A7794_CLK_SSI7>,
>> + <&mstp10_clks R8A7794_CLK_SSI6>,
>> + <&mstp10_clks R8A7794_CLK_SSI5>,
>> + <&mstp10_clks R8A7794_CLK_SSI4>,
>> + <&mstp10_clks R8A7794_CLK_SSI3>,
>> + <&mstp10_clks R8A7794_CLK_SSI2>,
>> + <&mstp10_clks R8A7794_CLK_SSI1>,
>> + <&mstp10_clks R8A7794_CLK_SSI0>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC9>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC8>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC7>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC6>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC5>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC4>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC3>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC2>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC1>,
>> + <&mstp10_clks R8A7794_CLK_SCU_SRC0>,
>> + <&mstp10_clks R8A7794_CLK_SCU_CTU0_MIX0>,
>> + <&mstp10_clks R8A7794_CLK_SCU_CTU1_MIX1>,
>> + <&mstp10_clks R8A7794_CLK_SCU_CTU0_MIX0>,
>> + <&mstp10_clks R8A7794_CLK_SCU_CTU1_MIX1>,
>> + <&mstp10_clks R8A7794_CLK_SCU_DVC0>,
>> + <&mstp10_clks R8A7794_CLK_SCU_DVC1>,
>> + <&audio_clka>, <&audio_clkb>, <&audio_clkc>,
>> + <&m2_clk>;
>> + clock-names = "ssi-all",
>> + "ssi.9", "ssi.8", "ssi.7", "ssi.6", "ssi.5",
>> + "ssi.4", "ssi.3", "ssi.2", "ssi.1", "ssi.0",
>> + "src.9", "src.8", "src.7", "src.6", "src.5",
>> + "src.4", "src.3", "src.2", "src.1", "src.0",
>> + "clk_a", "clk_b", "clk_c", "clk_i";
>
> This patch doesn't support "CTU/MIX/DVC".
It doesn't.
> Your "clocks" includes "R8A7794_CLK_SCU_CTUx_MIXx", and "R8A7794_CLK_SCU_DVCx",
> but "clock-names" doesn't include "ctu.x", "dvc.x".
Oops, thank you for noticing. Will fix.
MBR, Sergei
next prev parent reply other threads:[~2016-02-09 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 22:55 [PATCH 0/5] Add R8A7794 sound DT support Sergei Shtylyov
2016-02-08 22:57 ` [PATCH 1/5] ARM: dts: r8a7794: add audio clocks Sergei Shtylyov
2016-02-08 22:58 ` [PATCH 2/5] ARM: dts: r8a7794: add MSTP5 clocks Sergei Shtylyov
2016-02-08 22:59 ` [PATCH 3/5] ARM: dts: r8a7794: add MSTP10 clocks Sergei Shtylyov
2016-02-08 23:03 ` [PATCH 4/5] ARM: dts: r8a7794: add Audio-DMAC support Sergei Shtylyov
2016-02-08 23:04 ` [PATCH 5/5] ARM: dts: r8a7794 add sound support Sergei Shtylyov
2016-02-09 0:08 ` Kuninori Morimoto
2016-02-09 10:52 ` Sergei Shtylyov [this message]
2016-02-09 19:50 ` Simon Horman
2016-02-09 20:25 ` Sergei Shtylyov
2016-02-10 0:32 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B9C4D9.6020808@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).