From: Brijesh Singh <brijesh.singh@amd.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: brijesh.singh@amd.com,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
mark.rutland@arm.com, devicetree@vger.kernel.org, arm@kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
leo.duran@amd.com, galak@codeaurora.org, thomas.lendacky@amd.com,
brijeshkumar.singh@amd.com
Subject: Re: [PATCH V2 09/12] dtb: amd: Add KCS device tree node
Date: Tue, 9 Feb 2016 10:11:38 -0600 [thread overview]
Message-ID: <56BA0FBA.1010202@amd.com> (raw)
In-Reply-To: <15181064.RzzsN4CWec@wuerfel>
Hi,
On 02/09/2016 10:00 AM, Arnd Bergmann wrote:
>
> The important part for interrupt/reg/... names is that you must use exactly the
> names that are listed in the binding. If there is no name in there, it's better
> not to add the name property.
>
> The other point is that "ipmi_kcs" is a name that is picked really badly, as it
> uses a '_' character while DT properties by convention use '-' between names,
> and the name of the IRQ is the same as the device itself, which is really
> not a useful way to disambiguate multiple interrupts in the same device, if
> someone ever adds another irq line.
>
Sure we will drop the name field. Thanks.
> Arnd
>
next prev parent reply other threads:[~2016-02-09 16:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 17:59 [PATCH V2 00/12] dtb: amd: Miscelleneous Updates for AMD Seattle DTS Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 01/12] MAINTAINERS: Adding Maintainers for AMD Seattle Device Tree Suravee Suthikulpanit
2016-02-08 21:38 ` Olof Johansson
2016-02-09 19:49 ` Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 02/12] dtb: amd: Fix GICv2 hypervisor and virtual interface sizes Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree Suravee Suthikulpanit
2016-02-09 14:57 ` Arnd Bergmann
2016-02-10 21:13 ` Suravee Suthikulpanit
[not found] ` <56BBA80E.6090205-5C7GfCeVMHo@public.gmane.org>
2016-02-10 21:19 ` Arnd Bergmann
2016-02-11 21:23 ` Olof Johansson
[not found] ` <CAOesGMgOmmXY2X2bwOd-6m117o6VPpqer6BXrzNePuRPoiz_Nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-11 22:59 ` Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 04/12] dtb: amd: Fix typo in SPI device nodes Suravee Suthikulpanit
[not found] ` <1454954357-8395-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2016-02-08 17:59 ` [PATCH V2 05/12] dtb: amd: Misc changes for I2C " Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 06/12] dtb: amd: Misc changes for SATA device tree nodes Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 07/12] dtb: amd: Misc changes for GPIO devices Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 08/12] dtb: amd: Add PERF CCN-504 device tree node Suravee Suthikulpanit
2016-02-09 14:58 ` Arnd Bergmann
2016-02-09 23:35 ` Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 09/12] dtb: amd: Add KCS " Suravee Suthikulpanit
2016-02-09 14:59 ` Arnd Bergmann
2016-02-09 15:47 ` Brijesh Singh
2016-02-09 16:00 ` Arnd Bergmann
2016-02-09 16:11 ` Brijesh Singh [this message]
2016-02-08 17:59 ` [PATCH V2 10/12] dtb: amd: Add AMD XGBE device tree file Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 11/12] dtb: amd: Add support for new AMD Overdrive boards Suravee Suthikulpanit
2016-02-08 17:59 ` [PATCH V2 12/12] dtb: amd: Add support for AMD/Linaro 96Boards Enterprise Edition Server board Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA0FBA.1010202@amd.com \
--to=brijesh.singh@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=brijeshkumar.singh@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=leo.duran@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).