From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Date: Tue, 9 Feb 2016 16:17:33 +0000 Message-ID: <56BA111D.9050807@arm.com> References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56B9D62E.8080003@arm.com> <20160209160812.GC9332@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160209160812.GC9332@leverpostej> Sender: linux-kernel-owner@vger.kernel.org To: Mark Rutland , Stuart Yoder Cc: Marc Zyngier , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "david.daney@cavium.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 09/02/16 16:08, Mark Rutland wrote: [...] >>>> having msi-map-mask clash with a nonzero rid-base, as that's another >>>> thing one can easily get wrong. [...] >>>> + if (rid_base & ~map_mask) { >>>> + dev_err(parent_dev, >>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid- >>> base (0x%x)\n", >>>> + map_mask, rid_base); >>>> + return rid_out; >>>> + } [...] >> msi-map = <0x0100 &its 0x11 0x1>; >> msi-map-mask = <0xff>; >> > > I'd say that this is an inconsistent set of properties, and it's > probably worth warning if we encounter this. There is no possible way > that rid-base can be encountered. Indeed ;) Robin. > Thanks, > Mark. >