From: Timur Tabi <timur@codeaurora.org>
To: fu.wei@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, wim@iguana.be, linux@roeck-us.net,
corbet@lwn.net, catalin.marinas@arm.com, will.deacon@arm.com,
Suravee.Suthikulpanit@amd.com
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, rruigrok@codeaurora.org,
harba@codeaurora.org, cov@codeaurora.org, dyoung@redhat.com,
panand@redhat.com, graeme.gregory@linaro.org,
al.stone@linaro.org, hanjun.guo@linaro.org, jcm@redhat.com,
arnd@arndb.de, leo.duran@amd.com, sudeep.holla@arm.com
Subject: Re: [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver
Date: Tue, 9 Feb 2016 11:39:26 -0600 [thread overview]
Message-ID: <56BA244E.1020402@codeaurora.org> (raw)
In-Reply-To: <1455037240-16192-5-git-send-email-fu.wei@linaro.org>
fu.wei@linaro.org wrote:
> + if (!action)
> + dev_warn(dev, "fall back to signle stage mode.\n");
"falling back to single stage mode"
Acked-by: Timur Tabi <timur@codeaurora.org>
The whole "calculate the timeouts different if 'action' is enabled"
seems clunky to me, but I can't think of a better way to handle it.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
next prev parent reply other threads:[~2016-02-09 17:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 17:00 [PATCH v11 0/4] Watchdog: introduce ARM SBSA watchdog driver fu.wei
2016-02-09 17:00 ` [PATCH v11 1/4] Documentation: add sbsa-gwdt driver documentation fu.wei
2016-02-09 17:00 ` [PATCH v11 2/4] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts fu.wei
2016-02-09 17:00 ` [PATCH v11 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi fu.wei
[not found] ` <1455037240-16192-4-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-02-10 20:56 ` Suravee Suthikulpanit
2016-02-14 9:26 ` Fu Wei
2016-02-09 17:00 ` [PATCH v11 4/4] Watchdog: introduce ARM SBSA watchdog driver fu.wei
2016-02-09 17:39 ` Timur Tabi [this message]
[not found] ` <56BA244E.1020402-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-02-09 17:47 ` Fu Wei
2016-02-10 14:57 ` Mathieu Poirier
2016-02-16 9:25 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA244E.1020402@codeaurora.org \
--to=timur@codeaurora.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=cov@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dyoung@redhat.com \
--cc=fu.wei@linaro.org \
--cc=galak@codeaurora.org \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcm@redhat.com \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rruigrok@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).