From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/5] dt/bindings: Add binding for the DA8xx MUSB driver Date: Thu, 11 Feb 2016 16:53:35 +0300 Message-ID: <56BC925F.6010809@cogentembedded.com> References: <1455188466-10879-1-git-send-email-petr@barix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455188466-10879-1-git-send-email-petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Petr Kulhavy , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello. On 2/11/2016 2:01 PM, Petr Kulhavy wrote: > This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. This patch describes bindings, not adds support. > Signed-off-by: Petr Kulhavy > --- > .../devicetree/bindings/usb/da8xx-usb.txt | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/da8xx-usb.txt > > diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt > new file mode 100644 > index 0000000..62dcc51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt > @@ -0,0 +1,47 @@ > +TI DA8xx MUSB > +~~~~~~~~~~~~~ > +For DA830 and DA850 platforms. I'd suggest "DA8xx/OMAP-L1x/AM17xx/AM18xx" again. > + > +Required properties: > +~~~~~~~~~~~~~~~~~~~~ > + - compatible : Should be set to "ti,da830-musb". > + > + - reg: Offset and length of the USB controller register set. > + > + - interrupts: The USB interrupt number. > + > + - interrupt-names: Should be set to "mc". > + > + - dr_mode: The USB operation mode. Should be one of "host", "peripheral" or "otg". > + > + - mentor,power : Specifies the maximum current in milliamperes the controller can > + supply in host mode. > + > + - ti,phy20-refclock-frequency : Integer. Defines the USB 2.0 PHY reference clock input Maybe "ti,usb2-phy-refclock-frequency"? > + frequency in Hz in case the clock is generated by the internal PLL. > + Supported values are 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz > + > + > +Optional properties: > +~~~~~~~~~~~~~~~~~~~~ > + - ti,phy20-clkmux-pll: Boolean. Defines the USB 2.0 PHY reference clock source. Maybe "ti,usb2-phy-clkmux-pll"? > + If present the internal PLL is used as a clock source, otherwise the external > + USB_REFCLKIN pin is used. > + > +Example: > + > + usb20: usb@1e00000 { > + compatible = "ti,da830-musb"; > + reg = <0x00200000 0x10000>; > + interrupt-parent = <&intc>; > + interrupts = <58>; > + interrupt-names = "mc"; > + > + dr_mode = "host"; > + mentor,power = <500>; > + > + ti,phy20-clkmux-pll; > + ti,phy20-refclock-frequency = <24000000>; In principle these 2 should belong to the USB PHY subnode... [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html