From: Frank Rowand <frowand.list@gmail.com>
To: Marc Zyngier <marc.zyngier@arm.com>, robh+dt@kernel.org
Cc: Robin Murphy <robin.murphy@arm.com>,
grant.likely@linaro.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, david.daney@cavium.com,
stuart.yoder@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base
Date: Thu, 11 Feb 2016 10:10:49 -0800 [thread overview]
Message-ID: <56BCCEA9.4050509@gmail.com> (raw)
In-Reply-To: <56BC6ABA.5020605@arm.com>
On 2/11/2016 3:04 AM, Marc Zyngier wrote:
> On 09/02/16 11:04, Robin Murphy wrote:
>> The existing msi-map code is fine for shifting the entire RID space
>> upwards, but attempting finer-grained remapping reveals a bug. It turns
>> out that we are mistakenly treating the msi-base part as an offset, not
>> as a new base to remap onto, so things get squiffy when rid-base is
>> nonzero. Fix this, and at the same time add a sanity check against
>> having msi-map-mask clash with a nonzero rid-base, as that's another
>> thing one can easily get wrong.
>>
>> CC: <stable@vger.kernel.org>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>
> Rob, Frank,
>
> Are you willing to take this one through the OF tree? Or should we route
> it through the IRQ tree? It'd be good if it make it into 4.5.
>
> Thanks,
>
> M.
>
Just to be picky, I would like the patch to be split in two for easier
bisecting, but if Rob is happy with a single patch I'm ok with that.
Rob, will you pick this up?
Acked-by: Frank Rowand <frank.rowand@sonymobile.com>
-Frank
next prev parent reply other threads:[~2016-02-11 18:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 11:04 [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Robin Murphy
2016-02-09 12:06 ` Marc Zyngier
2016-02-09 15:56 ` Stuart Yoder
2016-02-09 16:08 ` Mark Rutland
2016-02-09 16:17 ` Robin Murphy
2016-02-09 18:19 ` Mark Rutland
2016-02-09 16:53 ` Stuart Yoder
2016-02-09 17:03 ` David Daney
[not found] ` <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-02-09 18:12 ` Stuart Yoder
2016-02-11 11:04 ` Marc Zyngier
2016-02-11 18:10 ` Frank Rowand [this message]
[not found] ` <56BC6ABA.5020605-5wv7dgnIgG8@public.gmane.org>
2016-02-11 23:15 ` Rob Herring
[not found] ` <CAL_JsqLScMdfUAtMPDGWphc_PZp4K-c0MfjRZh9G7=A9pLZu9Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-12 8:32 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCCEA9.4050509@gmail.com \
--to=frowand.list@gmail.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=stuart.yoder@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).