From: Sudeep Holla <sudeep.holla@arm.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mailbox: mailbox-test: use print_hex_dump_bytes to allow dynamic printk
Date: Fri, 12 Feb 2016 09:32:15 +0000 [thread overview]
Message-ID: <56BDA69F.5060102@arm.com> (raw)
In-Reply-To: <20160212091218.GR20693@x1>
On 12/02/16 09:12, Lee Jones wrote:
> On Thu, 11 Feb 2016, Sudeep Holla wrote:
>
>> Reduce the logging from info to debug. Also use print_hex_dump_bytes
>> instead as it has support for dynamic printk providing options to
>> conditionally enable/disable these logs.
>
> Printing out the data in this way is kinda the point of the driver.
> But if you don't have a use for it, then I guess it's okay to
> downgrade it to DEBUG, as turning debug on, or hacking the driver back
> again are trivial actions.
>
Agreed, I wanted check the same by adding additional note but forgot.
Sorry for missing that.
One of the reasons I preferred this it's easy to switch it on or off via
debug level or dynamic debug. It's useful when the test application
using these sysfs also logs and ends up cluttered by kernel logs.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-02-12 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 17:13 [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer Sudeep Holla
[not found] ` <1455210808-29395-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2016-02-11 17:13 ` [PATCH 1/4] mailbox: mailbox-test: rename driver as generic test driver Sudeep Holla
2016-02-12 9:08 ` Lee Jones
2016-02-15 12:17 ` [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer Sudeep Holla
2016-02-15 12:31 ` Jassi Brar
2016-02-15 12:38 ` Sudeep Holla
2016-02-11 17:13 ` [PATCH 2/4] mailbox: mailbox-test: fix the compatible string Sudeep Holla
2016-02-12 9:08 ` Lee Jones
[not found] ` <1455210808-29395-3-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2016-02-12 16:49 ` Rob Herring
2016-02-11 17:13 ` [PATCH 3/4] mailbox: mailbox-test: use print_hex_dump_bytes to allow dynamic printk Sudeep Holla
[not found] ` <1455210808-29395-4-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2016-02-12 9:12 ` Lee Jones
2016-02-12 9:32 ` Sudeep Holla [this message]
2016-02-11 17:13 ` [PATCH 4/4] mailbox: mailbox-test: add support for separate tx/rx buffer with single channel Sudeep Holla
[not found] ` <1455210808-29395-5-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2016-02-12 9:15 ` Lee Jones
2016-02-12 9:34 ` Sudeep Holla
2016-02-12 9:17 ` [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer Lee Jones
2016-02-12 9:41 ` Sudeep Holla
[not found] ` <56BDA8E3.8060800-5wv7dgnIgG8@public.gmane.org>
2016-02-15 12:14 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BDA69F.5060102@arm.com \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).