From: Andrew Duggan <aduggan@synaptics.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Christopher Heiny <cheiny@synaptics.com>,
Stephen Chandler Paul <cpaul@redhat.com>,
Vincent Huang <vincent.huang@tw.synaptics.com>,
Chris Healy <cphealy@gmail.com>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11
Date: Fri, 12 Feb 2016 09:20:46 -0800 [thread overview]
Message-ID: <56BE146E.7050107@synaptics.com> (raw)
In-Reply-To: <20160212154427.GA8795@rob-hp-laptop>
On 02/12/2016 07:47 AM, Rob Herring wrote:
> On Wed, Feb 10, 2016 at 02:24:34PM -0800, Andrew Duggan wrote:
>> 2D sensors have several parameter which can be set in the platform data.
>> This patch adds support for getting those values from devicetree.
>>
>> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
>> ---
>> .../bindings/input/rmi4/rmi_2d_sensor.txt | 56 +++++++++++
>> .../bindings/input/touchscreen/touchscreen.txt | 2 +
>> drivers/input/rmi4/rmi_2d_sensor.c | 108 +++++++++++++++++++++
>> drivers/input/rmi4/rmi_2d_sensor.h | 3 +
>> drivers/input/rmi4/rmi_f11.c | 7 +-
>> 5 files changed, 175 insertions(+), 1 deletion(-)
>> create mode 100644 Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> index ac23caf..d6674de 100644
>> --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> @@ -18,6 +18,8 @@ Optional properties for Touchscreens:
>> - touchscreen-inverted-y : Y axis is inverted (boolean)
>> - touchscreen-swapped-x-y : X and Y axis are swapped (boolean)
>> Swapping is done after inverting the axis
>> + - touchscreen-mm-x : horizontal length in mm of the touchscreen
>> + - touchscreen-mm-y : vertical length in mm of the touchscreen
> As I mentioned on v3, put the units on the end.
Oh sorry! I see you did mention that in v3 and I must have missed it.
Thanks,
Andrew
> Rob
prev parent reply other threads:[~2016-02-12 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 22:24 [PATCH v5 05/10] Input: synaptics-rmi4: Add device tree support for 2d sensors and F11 Andrew Duggan
2016-02-12 15:47 ` Rob Herring
2016-02-12 17:20 ` Andrew Duggan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE146E.7050107@synaptics.com \
--to=aduggan@synaptics.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cheiny@synaptics.com \
--cc=cpaul@redhat.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).