From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3 0/3] Allow iio_hwmon to accept hypen in node names Date: Tue, 16 Feb 2016 19:37:45 -0800 Message-ID: <56C3EB09.1050803@roeck-us.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sanchayan Maity , shawnguo@kernel.org Cc: jdelvare@suse.com, stefan@agner.ch, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org List-Id: devicetree@vger.kernel.org On 02/15/2016 09:00 PM, Sanchayan Maity wrote: > Hello, > > Initial versions of the patchset intended to introduce the use of > iio_hwmon for Vybrid SoC's. Currently the iio_hwmon driver has two > users and as per the binding documentation, the node names use the > underscore. Use of hypen in device tree node names is acceptable, > however currently the hwmon core code rejects it due to perhaps user > space not liking the hypen and getting confused. > > As per Guenter Roeck's suggestion, the first patch looks for a hypen > and replaces it with a underscore in the probe call of iio_hwmon driver > before calling hwmon_device_register_with_groups for registration. Any > users of iio_hwmon driver can now use hypen in the node name. > > As per Shawn's suggestion, the existing users have been changed to use > the hypen instead of the underscore and the iio-bindings document > updated. Third patch introduces the usage for Vybrid itself. > > Patchset is based on top of shawn's for-next branch. > > Feedbacks and comments most welcome. Thank you for feedbacks. > > @Guenter > I hope I understood and implemented correctly what you had in mind. > Yes. Series applied to hwmon-next (if the dts changes also end up in an arm branch, no harm done). Thanks, Guenter