From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Murzin Subject: Re: [PATCH v3 05/10] serial: mps2-uart: add support for early console Date: Fri, 19 Feb 2016 09:45:18 +0000 Message-ID: <56C6E42E.5070601@arm.com> References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <1455617295-23736-6-git-send-email-vladimir.murzin@arm.com> <56C31F9F.10000@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56C31F9F.10000-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Cc: Mark Rutland , devicetree , Russell King , Pawel Moll , Arnd Bergmann , ijc+devicetree , Greg Kroah-Hartman , Daniel Lezcano , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Kumar Gala , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , =?windows-1252?Q?Uwe_Kleine-K=F6nig?= , Thomas Gleixner , "linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jiri Slaby , linux-arm Mailing List List-Id: devicetree@vger.kernel.org On 16/02/16 13:09, Vladimir Murzin wrote: >>> +EARLYCON_DECLARE(mps2, mps2_early_console_setup); >>> >> +OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup); >> > >> > IIRC Peter Hurley mentioned you don't need to put both anymore, OF_ >> > one is enough. >> > > I've just tried with OF_ only and seems it works fine. Thanks for > pointing at it! > ..and the reason for that was that I had stdout pointing at uart node. Now, while testing v4 I end-up with configuration: 1) no EARLYCON_DECLARE in mps2-uart.c 2) stdout not set 3) cmdline has "earlycon=mps2,0x40004000 console=/dev/ttyMPS" and I don't see bootconsole, but if I avoid 1) everything works fine. So, I'd leave EARLYCON_DECLARE in this patch. Cheers Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html