From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Peter Seiderer <ps.report@gmx.net>, linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Eric Nelson <eric.nelson@boundarydevices.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support
Date: Mon, 22 Feb 2016 13:48:56 -0700 [thread overview]
Message-ID: <56CB7438.5030102@boundarydevices.com> (raw)
In-Reply-To: <1456171421-10044-1-git-send-email-ps.report@gmx.net>
On 2/22/2016 1:03 PM, Peter Seiderer wrote:
> Regulator stuff and pin configuration copied from imx6qdl-nitrogen6_max.dtsi
> and checked against Boundary Devices linux kernel tree ([1]).
>
> [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.14.28_1.0.0_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index c6c590d..81f8c5c 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -85,9 +85,21 @@
> enable-active-high;
> };
>
> - reg_can_xcvr: regulator@3 {
> + reg_usb_h1_vbus: regulator@3 {
> compatible = "regulator-fixed";
> reg = <3>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbh1>;
> + regulator-name = "usb_h1_vbus";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + reg_can_xcvr: regulator@4 {
> + compatible = "regulator-fixed";
> + reg = <4>;
> regulator-name = "CAN XCVR";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> @@ -96,9 +108,9 @@
> gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;
> };
>
> - reg_wlan_vmmc: regulator@4 {
> + reg_wlan_vmmc: regulator@5 {
> compatible = "regulator-fixed";
> - reg = <4>;
> + reg = <5>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wlan_vmmc>;
> regulator-name = "reg_wlan_vmmc";
> @@ -515,6 +527,12 @@
> >;
> };
>
> + pinctrl_usbh1: usbh1grp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x0b0b0
I'm ok with this patch, but a more correct fix would be to add a
reset-gpios to usbh1 instead, as this is a reset pin for
a usb hub. So if nobody else has a problem,
Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
> + >;
> + };
> +
> pinctrl_usbotg: usbotggrp {
> fsl,pins = <
> MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> @@ -632,6 +650,7 @@
> };
>
> &usbh1 {
> + vbus-supply = <®_usb_h1_vbus>;
> status = "okay";
> };
>
>
next prev parent reply other threads:[~2016-02-22 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 20:03 [PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support Peter Seiderer
2016-02-22 20:48 ` Troy Kisky [this message]
[not found] ` <56CB7438.5030102-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2016-02-22 20:53 ` Fabio Estevam
2016-02-24 9:33 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB7438.5030102@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.nelson@boundarydevices.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ps.report@gmx.net \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).