* [PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support
@ 2016-02-22 20:03 Peter Seiderer
2016-02-22 20:48 ` Troy Kisky
0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2016-02-22 20:03 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Russell King,
Kumar Gala, Ian Campbell, Mark Rutland, Pawel Moll, Rob Herring,
Sascha Hauer, Shawn Guo, Eric Nelson
Regulator stuff and pin configuration copied from imx6qdl-nitrogen6_max.dtsi
and checked against Boundary Devices linux kernel tree ([1]).
[1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.14.28_1.0.0_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
Signed-off-by: Peter Seiderer <ps.report-hi6Y0CQ0nG0@public.gmane.org>
---
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 25 ++++++++++++++++++++++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
index c6c590d..81f8c5c 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
@@ -85,9 +85,21 @@
enable-active-high;
};
- reg_can_xcvr: regulator@3 {
+ reg_usb_h1_vbus: regulator@3 {
compatible = "regulator-fixed";
reg = <3>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbh1>;
+ regulator-name = "usb_h1_vbus";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ reg_can_xcvr: regulator@4 {
+ compatible = "regulator-fixed";
+ reg = <4>;
regulator-name = "CAN XCVR";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
@@ -96,9 +108,9 @@
gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;
};
- reg_wlan_vmmc: regulator@4 {
+ reg_wlan_vmmc: regulator@5 {
compatible = "regulator-fixed";
- reg = <4>;
+ reg = <5>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_wlan_vmmc>;
regulator-name = "reg_wlan_vmmc";
@@ -515,6 +527,12 @@
>;
};
+ pinctrl_usbh1: usbh1grp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x0b0b0
+ >;
+ };
+
pinctrl_usbotg: usbotggrp {
fsl,pins = <
MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
@@ -632,6 +650,7 @@
};
&usbh1 {
+ vbus-supply = <®_usb_h1_vbus>;
status = "okay";
};
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support
2016-02-22 20:03 [PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support Peter Seiderer
@ 2016-02-22 20:48 ` Troy Kisky
[not found] ` <56CB7438.5030102-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Troy Kisky @ 2016-02-22 20:48 UTC (permalink / raw)
To: Peter Seiderer, linux-kernel
Cc: Mark Rutland, devicetree, Russell King, Pawel Moll, Ian Campbell,
Eric Nelson, Rob Herring, Sascha Hauer, Kumar Gala, Shawn Guo,
linux-arm-kernel
On 2/22/2016 1:03 PM, Peter Seiderer wrote:
> Regulator stuff and pin configuration copied from imx6qdl-nitrogen6_max.dtsi
> and checked against Boundary Devices linux kernel tree ([1]).
>
> [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.14.28_1.0.0_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index c6c590d..81f8c5c 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -85,9 +85,21 @@
> enable-active-high;
> };
>
> - reg_can_xcvr: regulator@3 {
> + reg_usb_h1_vbus: regulator@3 {
> compatible = "regulator-fixed";
> reg = <3>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbh1>;
> + regulator-name = "usb_h1_vbus";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio7 12 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + reg_can_xcvr: regulator@4 {
> + compatible = "regulator-fixed";
> + reg = <4>;
> regulator-name = "CAN XCVR";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> @@ -96,9 +108,9 @@
> gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;
> };
>
> - reg_wlan_vmmc: regulator@4 {
> + reg_wlan_vmmc: regulator@5 {
> compatible = "regulator-fixed";
> - reg = <4>;
> + reg = <5>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_wlan_vmmc>;
> regulator-name = "reg_wlan_vmmc";
> @@ -515,6 +527,12 @@
> >;
> };
>
> + pinctrl_usbh1: usbh1grp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x0b0b0
I'm ok with this patch, but a more correct fix would be to add a
reset-gpios to usbh1 instead, as this is a reset pin for
a usb hub. So if nobody else has a problem,
Acked-by: Troy Kisky <troy.kisky@boundarydevices.com>
> + >;
> + };
> +
> pinctrl_usbotg: usbotggrp {
> fsl,pins = <
> MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> @@ -632,6 +650,7 @@
> };
>
> &usbh1 {
> + vbus-supply = <®_usb_h1_vbus>;
> status = "okay";
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-24 9:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 20:03 [PATCH v1] ARM: dts: nitrogen6x: add USB host 1 support Peter Seiderer
2016-02-22 20:48 ` Troy Kisky
[not found] ` <56CB7438.5030102-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2016-02-22 20:53 ` Fabio Estevam
2016-02-24 9:33 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).