devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Vaussard <florian.vaussard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
	Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	Florian Vaussard
	<florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
Subject: Re: [PATCH v2 2/2] ASoC: ads117x: Add device tree compatible string
Date: Wed, 24 Feb 2016 08:36:37 +0100	[thread overview]
Message-ID: <56CD5D85.8070501@gmail.com> (raw)
In-Reply-To: <1454686334-9668-3-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>

Hello Mark,

On 02/05/2016 04:32 PM, Florian Vaussard wrote:
> This patch adds the necessary device tree compatible string to allow DT
> probing.
> 
> Signed-off-by: Florian Vaussard <florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
> ---
>  sound/soc/codecs/ads117x.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c
> index 1222282..c5be1bd 100644
> --- a/sound/soc/codecs/ads117x.c
> +++ b/sound/soc/codecs/ads117x.c
> @@ -20,6 +20,8 @@
>  #include <sound/initval.h>
>  #include <sound/soc.h>
>  
> +#include <linux/of.h>
> +
>  #define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000)
>  #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
>  
> @@ -75,9 +77,19 @@ static int ads117x_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +#if defined(CONFIG_OF)
> +static const struct of_device_id ads117x_dt_ids[] = {
> +	{ .compatible = "ti,ads1174" },
> +	{ .compatible = "ti,ads1178" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ads117x_dt_ids);
> +#endif
> +
>  static struct platform_driver ads117x_codec_driver = {
>  	.driver = {
>  			.name = "ads117x-codec",
> +			.of_match_table = of_match_ptr(ads117x_dt_ids),
>  	},
>  
>  	.probe = ads117x_probe,
> 

Do you have any more comments on this patch?

Best regards,
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-02-24  7:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 15:32 [PATCH v2 0/2] ASoC: ads117x: Add device tree support for TI ADS117x Florian Vaussard
     [not found] ` <1454686334-9668-1-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-02-05 15:32   ` [PATCH v2 1/2] ASoC: ads117x: Add bindings documentation for TI ADS117x ADC Florian Vaussard
     [not found]     ` <1454686334-9668-2-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-02-08 19:26       ` Rob Herring
2016-02-05 15:32   ` [PATCH v2 2/2] ASoC: ads117x: Add device tree compatible string Florian Vaussard
     [not found]     ` <1454686334-9668-3-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-02-24  7:36       ` Florian Vaussard [this message]
     [not found]         ` <56CD5D85.8070501-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-26  2:14           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CD5D85.8070501@gmail.com \
    --to=florian.vaussard-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=perex-/Fr2/VpizcU@public.gmane.org \
    --cc=tiwai-IBi9RG/b67k@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).