[PATCH v2 0/2] ASoC: ads117x: Add device tree support for TI ADS117x

[PATCH v2 0/2] ASoC: ads117x: Add device tree support for TI ADS117x

[Florian Vaussard]

Hello,

This series adds device tree support for Texas Instruments ADS117x
ADC chip. The first patch adds the binding documentation, while the second
patch adds the compatible string into the driver. No further properties are
necessary.

Best regards,
Florian

---
Since v1:
- Updated topic for the documentation patch
- Removed wildcard in compatible string
---

Florian Vaussard (2):
  ASoC: ads117x: Add bindings documentation for TI ADS117x ADC
  ASoC: ads117x: Add device tree compatible string

 Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++
 sound/soc/codecs/ads117x.c                             | 12 ++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt

-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] ASoC: ads117x: Add bindings documentation for TI ADS117x ADC

[Florian Vaussard]

Currently the binding is only made of the compatible string.

Signed-off-by: Florian Vaussard <florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
---
 Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt

diff --git a/Documentation/devicetree/bindings/sound/ti,ads117x.txt b/Documentation/devicetree/bindings/sound/ti,ads117x.txt
new file mode 100644
index 0000000..7db19b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/ti,ads117x.txt
@@ -0,0 +1,11 @@
+Texas Intstruments ADS117x ADC
+
+Required properties:
+
+  - compatible : "ti,ads1174" or "ti,ads1178"
+
+Example:
+
+ads1178 {
+	compatible = "ti,ads1178";
+};
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] ASoC: ads117x: Add device tree compatible string

[Florian Vaussard]

This patch adds the necessary device tree compatible string to allow DT
probing.

Signed-off-by: Florian Vaussard <florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
---
 sound/soc/codecs/ads117x.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c
index 1222282..c5be1bd 100644
--- a/sound/soc/codecs/ads117x.c
+++ b/sound/soc/codecs/ads117x.c
@@ -20,6 +20,8 @@
 #include <sound/initval.h>
 #include <sound/soc.h>
 
+#include <linux/of.h>
+
 #define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000)
 #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
 
@@ -75,9 +77,19 @@ static int ads117x_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#if defined(CONFIG_OF)
+static const struct of_device_id ads117x_dt_ids[] = {
+	{ .compatible = "ti,ads1174" },
+	{ .compatible = "ti,ads1178" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, ads117x_dt_ids);
+#endif
+
 static struct platform_driver ads117x_codec_driver = {
 	.driver = {
 			.name = "ads117x-codec",
+			.of_match_table = of_match_ptr(ads117x_dt_ids),
 	},
 
 	.probe = ads117x_probe,
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] ASoC: ads117x: Add bindings documentation for TI ADS117x ADC

[Rob Herring]

On Fri, Feb 05, 2016 at 04:32:13PM +0100, Florian Vaussard wrote:
> Currently the binding is only made of the compatible string.
> 
> Signed-off-by: Florian Vaussard <florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] ASoC: ads117x: Add device tree compatible string

[Florian Vaussard]

Hello Mark,

On 02/05/2016 04:32 PM, Florian Vaussard wrote:
> This patch adds the necessary device tree compatible string to allow DT
> probing.
> 
> Signed-off-by: Florian Vaussard <florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
> ---
>  sound/soc/codecs/ads117x.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c
> index 1222282..c5be1bd 100644
> --- a/sound/soc/codecs/ads117x.c
> +++ b/sound/soc/codecs/ads117x.c
> @@ -20,6 +20,8 @@
>  #include <sound/initval.h>
>  #include <sound/soc.h>
>  
> +#include <linux/of.h>
> +
>  #define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000)
>  #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
>  
> @@ -75,9 +77,19 @@ static int ads117x_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +#if defined(CONFIG_OF)
> +static const struct of_device_id ads117x_dt_ids[] = {
> +	{ .compatible = "ti,ads1174" },
> +	{ .compatible = "ti,ads1178" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ads117x_dt_ids);
> +#endif
> +
>  static struct platform_driver ads117x_codec_driver = {
>  	.driver = {
>  			.name = "ads117x-codec",
> +			.of_match_table = of_match_ptr(ads117x_dt_ids),
>  	},
>  
>  	.probe = ads117x_probe,
> 

Do you have any more comments on this patch?

Best regards,
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] ASoC: ads117x: Add device tree compatible string

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Wed, Feb 24, 2016 at 08:36:37AM +0100, Florian Vaussard wrote:
> >  			.name = "ads117x-codec",
> > +			.of_match_table = of_match_ptr(ads117x_dt_ids),
> >  	},
> >  
> >  	.probe = ads117x_probe,
> > 

> Do you have any more comments on this patch?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  Sending content
free pings just adds to the mail volume (if they are seen at all) and if 
something has gone wrong you'll have to resend the patches anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]