From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Tim Sander <tim@krieglstein.org>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dts: add specific compatible type for Terasic DE0-NANO-SoC Board
Date: Thu, 25 Feb 2016 10:56:28 -0600 [thread overview]
Message-ID: <56CF323C.90202@opensource.altera.com> (raw)
In-Reply-To: <20160225103820.GB747@pengutronix.de>
On 02/25/2016 04:38 AM, Steffen Trumtrar wrote:
> Hi Tim!
>
> On Thu, Feb 25, 2016 at 11:05:05AM +0100, Tim Sander wrote:
>> From: Tim Sander <tim@krieglstein.org>
>>
>> Add a more specific compatible string:"terasic,de0-nano-soc" for respective board.
>> Background: when checking for bootspec entries, some board specific fixups are
>> not apropriate for board of the same platform ("altr,socfpga-cyclone5").
>> The same aproach is taken with the EBV-Socrates board.
>>
>> Signed-off-by: Tim Sander <tim@krieglstein.org>
>> ---
>> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>> arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index 72e2c5a..d1f7803 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -230,6 +230,7 @@ synology Synology, Inc.
>> tbs TBS Technologies
>> tcl Toby Churchill Ltd.
>> technologic Technologic Systems
>> +terasic Terasic Inc.
>> thine THine Electronics, Inc.
>> ti Texas Instruments
>> tlm Trusted Logic Mobility
>
> You should IMHO split this up in two patches.
> First patch: add terasic
>
That's right. That patch will go through the DTS maintainer's tree.
>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
>> index afea364..704aa9d 100644
>> --- a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
>> @@ -18,7 +18,7 @@
>>
>> / {
>> model = "Terasic DE-0(Atlas)";
>> - compatible = "altr,socfpga-cyclone5", "altr,socfpga";
>> + compatible = "terasic,de0-nano-soc","altr,socfpga-cyclone5", "altr,socfpga";
>
So perhaps, "terasic,de0-sockit"?
> Second patch: this.
>
And I can take this one.
>>
>> chosen {
>> bootargs = "earlyprintk";
>
> The naming of this board still confuses me though.
> It has 3 different names now:
>
> - de0_sockit.dts
> - Terasic DE-0(Atlas)
> - de0-nano-soc
>
> And according to Terasic DE0-Nano-SoC is the same as Atlas-SoC with a different software?!
> So all three names are actually correct ?! Weird.
>
I had a hard time understanding this myself. But from what I gather
from[1], I just name the file de0_sockit.
Dinh
[1]
http://www.terasic.com.tw/cgi-bin/page/archive.pl?Language=English&CategoryNo=13&List=Simple#Category167
next prev parent reply other threads:[~2016-02-25 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 13:35 [PATCH] dts: add specific compatible type for Terasic DE0-NANO-SoC Board Tim Sander
2016-02-24 16:50 ` Dinh Nguyen
2016-02-25 10:05 ` [PATCH v2] " Tim Sander
2016-02-25 10:38 ` Steffen Trumtrar
2016-02-25 16:56 ` Dinh Nguyen [this message]
[not found] ` <56CF323C.90202-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-02-25 23:34 ` Tim Sander
2016-02-25 23:38 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF323C.90202@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=tim@krieglstein.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).