From: fixed-term.Oleksij.Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
To: Mark Brown <broonie@kernel.org>, Oleksij Rempel <linux@rempel-privat.de>
Cc: geert@linux-m68k.org, dirk.behme@de.bosch.com,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH 4/6] spi: davinci: set new SPI_FC_* flags
Date: Wed, 2 Mar 2016 07:57:48 +0100 [thread overview]
Message-ID: <56D68EEC.8000901@de.bosch.com> (raw)
In-Reply-To: <20160302021616.GP18327@sirena.org.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Beside, this probably should be done by main patch. In other case this
will brake compilation - ware bad for bisecting.
On 02.03.2016 03:16, Mark Brown wrote:
> On Tue, Mar 01, 2016 at 03:43:18PM +0100, Oleksij Rempel wrote:
>
>> - if (spi->mode & SPI_READY) { + if (spi->mode & SPI_FC_READY)
>> {
>
> This isn't setting new flags, this is replacing old flags with new
> ones which suggests that the patch renaming the flag needs to
> rename the flag in all the drivers...
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iF4EAREIAAYFAlbWjusACgkQHwImuRkmbWmj6QD/VWneJFfDJb4cq6e4mpM3AjER
wA5p8k5RMwBr3/SaETcA/iPDHn1jstR1tgN2lQV4tRBmAVBz8U5cyKefJlmuvwu1
=8TBT
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-03-02 6:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56D448E1.6090006@de.bosch.com>
[not found] ` <56D448E1.6090006-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2016-03-01 14:43 ` [PATCH 1/6] spi: add flow controll support Oleksij Rempel
[not found] ` <1456843400-20696-1-git-send-email-linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org>
2016-03-01 14:43 ` [PATCH 2/6] spi: add add flow control test driver Oleksij Rempel
2016-03-01 14:43 ` [PATCH 3/6] DT: add documentation for spi-fc-test driver Oleksij Rempel
[not found] ` <1456843400-20696-3-git-send-email-linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org>
2016-03-02 2:17 ` Mark Brown
2016-03-02 6:24 ` fixed-term.Oleksij.Rempel
2016-03-01 14:43 ` [PATCH 4/6] spi: davinci: set new SPI_FC_* flags Oleksij Rempel
[not found] ` <1456843400-20696-4-git-send-email-linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org>
2016-03-02 2:16 ` Mark Brown
2016-03-02 6:25 ` fixed-term.Oleksij.Rempel
[not found] ` <56D68754.3090405-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2016-03-02 10:48 ` Mark Brown
2016-03-02 6:57 ` fixed-term.Oleksij.Rempel [this message]
2016-03-01 14:43 ` [PATCH 5/6] spi: sun4i: " Oleksij Rempel
2016-03-01 14:43 ` [PATCH 6/6] spi: bitbang: " Oleksij Rempel
2016-03-02 1:32 ` [PATCH 1/6] spi: add flow controll support Mark Brown
2016-03-02 2:46 ` Mark Brown
2016-03-02 6:48 ` fixed-term.Oleksij.Rempel
[not found] ` <56D68CD7.8000203-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2016-03-02 10:55 ` Mark Brown
2016-03-02 11:21 ` fixed-term.Oleksij.Rempel
2016-03-02 12:26 ` Martin Sperl
2016-03-02 14:26 ` fixed-term.Oleksij.Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D68EEC.8000901@de.bosch.com \
--to=fixed-term.oleksij.rempel@de.bosch.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=geert@linux-m68k.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).