From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v2 2/2] bmips: add device tree example for BCM6358 Date: Thu, 3 Mar 2016 12:07:32 -0800 Message-ID: <56D89984.8020805@gmail.com> References: <1456054881-26787-2-git-send-email-noltari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1456054881-26787-2-git-send-email-noltari-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On 21/02/16 03:41, =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > This adds a device tree example for SFR Neufbox4 (Sercomm version), w= hich > also serves as a real example for brcm,bcm6358-leds. >=20 > Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas > --- [snip] > + periph_intc: periph_intc@fffe000c { Other examples are not doing this, but this should be: periph_intc: interrupt-controller@fffe000c to follow the ePAPR recommendations on naming nodes by function types. Everything else looks good, thanks! --=20 =46lorian -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html