Re: [PATCH 1/5] Subject: video: goldfishfb: add devicetree bindings

Re: [PATCH 1/5] Subject: video: goldfishfb: add devicetree bindings

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 2318 bytes --]


On 26/02/16 20:41, Alan wrote:
> From: Greg Hackmann <ghackmann-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> 
> Add device tree bindings to the Goldfish frame buffer interface.
> 
> Signed-off-by: Greg Hackmann <ghackmann-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Jin Qian <jinqian-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/goldfish/fb.txt |   17 +++++++++++++++++
>  drivers/video/fbdev/goldfishfb.c                  |    9 ++++++++-
>  2 files changed, 25 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/goldfish/fb.txt

Device tree bindings should also be sent to the devicetree mailing list.

> diff --git a/Documentation/devicetree/bindings/goldfish/fb.txt b/Documentation/devicetree/bindings/goldfish/fb.txt
> new file mode 100644
> index 0000000..c7d2d46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/goldfish/fb.txt
> @@ -0,0 +1,17 @@
> +Android Goldfish Framebuffer
> +
> +Andorid goldfish framebuffer device generated by android emulator.

Typo there in Android.

> +
> +Required properties:
> +
> +- compatible : should contain "google,goldfish-fb" to match emulator
> +- reg        : <registers mapping>
> +- interrupts : <interrupt mapping>
> +
> +Example:
> +
> +	goldfish_fb@9010000 {
> +		compatible = "google,goldfish-fb";
> +		reg = <0x9010000 0x100>;
> +		interrupts = <0x2>;
> +	};
> diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
> index 7f6c9e6..f0e651b 100644
> --- a/drivers/video/fbdev/goldfishfb.c
> +++ b/drivers/video/fbdev/goldfishfb.c
> @@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct of_device_id goldfish_fb_of_match[] = {
> +	{ .compatible = "google,goldfish-fb", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
>  
>  static struct platform_driver goldfish_fb_driver = {
>  	.probe		= goldfish_fb_probe,
>  	.remove		= goldfish_fb_remove,
>  	.driver = {
> -		.name = "goldfish_fb"
> +		.name = "goldfish_fb",
> +		.owner = THIS_MODULE,
> +		.of_match_table = goldfish_fb_of_match,
>  	}
>  };
>  
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]