devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lokesh Vutla <a0131933-l0cyMroinI0@public.gmane.org>
To: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: am43xx: fix edma memcpy channel allocation
Date: Mon, 14 Mar 2016 14:43:41 +0530	[thread overview]
Message-ID: <56E680C5.5000409@ti.com> (raw)
In-Reply-To: <1457946110-4612-1-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>



On Monday 14 March 2016 02:31 PM, Tero Kristo wrote:
> EDMA was allocating DMA channels 32 and 33 for memcpy usage, out of which
> channel 33 is actually used by DES crypto engine. This bad allocation of
> the channel causes a crash in the DES crypto engine, as the channel
> gets configured for memcpy usage instead of hardware <-> memory DMA.
> 
> Fixed by allocating DMA channels 58 and 59 for memcpy usage (I2C0 RX/TX),
> which are not used by anybody.

Reviewed-by: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>

Thanks and regards,
Lokesh

> 
> Signed-off-by: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
> Suggested-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/boot/dts/am4372.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 92068fb..cdd3d78 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -207,7 +207,7 @@
>  			ti,tptcs = <&edma_tptc0 7>, <&edma_tptc1 5>,
>  				   <&edma_tptc2 0>;
>  
> -			ti,edma-memcpy-channels = <32 33>;
> +			ti,edma-memcpy-channels = <58 59>;
>  		};
>  
>  		edma_tptc0: tptc@49800000 {
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-03-14  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  9:01 [PATCH] ARM: dts: am43xx: fix edma memcpy channel allocation Tero Kristo
     [not found] ` <1457946110-4612-1-git-send-email-t-kristo-l0cyMroinI0@public.gmane.org>
2016-03-14  9:13   ` Lokesh Vutla [this message]
2016-03-30 21:15   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E680C5.5000409@ti.com \
    --to=a0131933-l0cymroini0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=t-kristo-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).