devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: thierry.reding@gmail.com, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, bcousson@baylibre.com, tony@atomide.com,
	linux@arm.linux.org.uk, paul@pwsan.com,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com
Subject: Re: [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries
Date: Thu, 17 Mar 2016 10:45:59 -0500	[thread overview]
Message-ID: <56EAD137.1080502@ti.com> (raw)
In-Reply-To: <20160317150619.GA28105@rob-hp-laptop>



On 03/17/2016 10:06 AM, Rob Herring wrote:
> On Mon, Mar 07, 2016 at 07:23:41PM -0600, Franklin S Cooper Jr wrote:
>> Devices that utilize the OCP registers and/or PRCM registers and
>> register bit fields should be modelled using hwmod. Since eQEP, ePWM and
> s/modelled/modeled/

Will fix.
>
>> eCAP don't fall under this category, remove their hwmod entries.
>>
>> Instead these clocks simply use the clock that is pass through by its
>> parent PWMSS. Therefore, PWMSS handles the clock for itself and its
>> subdevices.
> Are you breaking compatibility with old DTs here? 

No. The first patch makes sure that the ecap and ehrpwm get
their clocks from their parent which is all they care about.
Old dtbs will have hwmod entries for ecap and ehrpwm which
will end up not doing anything.
>  
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>>  .../devicetree/bindings/pwm/pwm-tiecap.txt         |  1 -
>>  .../devicetree/bindings/pwm/pwm-tiehrpwm.txt       |  7 +-
>>  .../mach-omap2/omap_hwmod_33xx_43xx_common_data.h  | 18 -----
>>  .../omap_hwmod_33xx_43xx_interconnect_data.c       | 64 -----------------
>>  .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 84 ----------------------
>>  arch/arm/mach-omap2/omap_hwmod_33xx_data.c         |  9 ---
>>  arch/arm/mach-omap2/omap_hwmod_43xx_data.c         | 54 --------------
>>  7 files changed, 4 insertions(+), 233 deletions(-)

  reply	other threads:[~2016-03-17 15:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  1:23 [PATCH v5 0/6] ARM: am335x/am437x/dra7: Add PWM support for DRA7 Franklin S Cooper Jr
2016-03-08  1:23 ` [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent) Franklin S Cooper Jr
2016-03-17 22:37   ` Franklin S Cooper Jr.
2016-04-05  6:08   ` Sekhar Nori
2016-04-05 11:25     ` Franklin S Cooper Jr.
     [not found]       ` <5703A0C4.6010406-l0cyMroinI0@public.gmane.org>
2016-04-10 20:51         ` Paul Walmsley
     [not found]           ` <alpine.DEB.2.02.1604102048380.11457-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2016-04-11 11:49             ` Sekhar Nori
2016-04-11 12:45               ` Rob Herring
2016-04-12  8:10                 ` Sekhar Nori
     [not found] ` <1457400224-24797-1-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-08  1:23   ` [PATCH v5 2/6] ARM: dts: am437x/am33xx: Remove eCAP and ePWM hwmod properties Franklin S Cooper Jr
2016-03-08  6:55   ` [PATCH v5 0/6] ARM: am335x/am437x/dra7: Add PWM support for DRA7 Paul Walmsley
2016-03-08 17:04     ` Franklin S Cooper Jr.
2016-03-08  1:23 ` [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries Franklin S Cooper Jr
     [not found]   ` <1457400224-24797-4-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-17 15:06     ` Rob Herring
2016-03-17 15:45       ` Franklin S Cooper Jr. [this message]
2016-03-17 19:04         ` Rob Herring
2016-03-08  1:23 ` [PATCH v5 4/6] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr
2016-03-08  6:45   ` Paul Walmsley
2016-04-10 18:57     ` Paul Walmsley
2016-03-08  1:23 ` [PATCH v5 5/6] ARM: dts: DRA7: Add TBCLK " Franklin S Cooper Jr
2016-04-11 20:21   ` Tony Lindgren
2016-04-11 20:27     ` Tony Lindgren
2016-03-08  1:23 ` [PATCH v5 6/6] ARM: dts: DRA7: Add dt nodes " Franklin S Cooper Jr
     [not found]   ` <1457400224-24797-7-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-17 15:11     ` Rob Herring
2016-03-17 15:53       ` Franklin S Cooper Jr.
2016-04-11 20:21         ` Tony Lindgren
2016-04-19 16:20           ` Franklin S Cooper Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EAD137.1080502@ti.com \
    --to=fcooper@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=paul@pwsan.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).