From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: k.kozlowski@samsung.com, kgene@kernel.org, tomasz.figa@gmail.com,
jh80.chung@samsung.com, andi.shyti@samsung.com,
inki.dae@samsung.com, sw0312.kim@samsung.com,
pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock
Date: Fri, 25 Mar 2016 10:50:30 +0100 [thread overview]
Message-ID: <56F509E6.7080807@samsung.com> (raw)
In-Reply-To: <56F47ABC.7060006@samsung.com>
Hi Chanwoo,
On 03/25/2016 12:39 AM, Chanwoo Choi wrote:
> diff --git a/include/dt-bindings/clock/exynos3250.h
> b/include/dt-bindings/clock/exynos3250.h
>> index ddb874130d86..c796ff02ceeb 100644
>> --- a/include/dt-bindings/clock/exynos3250.h
>> +++ b/include/dt-bindings/clock/exynos3250.h
...
>> -#define CLK_NR_CLKS 249
>> +#define CLK_NR_CLKS 250
What do you think about putting all the changes to include/dt-bindings/
clock/exynos3250.h into a separate patch? Now in patch 3/8 there
is being changed again what was added in patch 2/8. However, my main
point is to have a minimum required in a common topic branch for the clk
and the arm-soc trees, so there is no need for arm-soc to pull all
the drives/clk changes.
It might not be that sensible in case of just those 2 patches in your
series, nevertheless it would be good to keep that in mind for future
submissions.
next prev parent reply other threads:[~2016-03-25 9:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 7:38 [PATCH v3 0/8] ARM: dts: Add new Exynos3250-based ARTIK5 module dtsi file Chanwoo Choi
2016-03-15 7:38 ` [PATCH v3 1/8] ARM: dts: Add initial pin configuration for exynos3250-rinato Chanwoo Choi
2016-03-15 7:38 ` [PATCH v3 2/8] clk: samsung: exynos3250: Add UART2 clock Chanwoo Choi
2016-03-24 23:39 ` Chanwoo Choi
2016-03-15 7:38 ` [PATCH v3 3/8] clk: samsung: exynos3250: Add MMC2 clock Chanwoo Choi
2016-03-24 23:39 ` Chanwoo Choi
2016-03-25 9:50 ` Sylwester Nawrocki [this message]
2016-03-28 0:44 ` Chanwoo Choi
[not found] ` <56F87E83.7060100-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-29 1:48 ` Krzysztof Kozlowski
2016-03-30 9:37 ` Sylwester Nawrocki
[not found] ` <56F9DEE6.8020203-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-31 11:04 ` Sylwester Nawrocki
2016-04-01 0:15 ` Krzysztof Kozlowski
2016-03-30 9:30 ` Sylwester Nawrocki
2016-03-15 7:38 ` [PATCH v3 4/8] ARM: dts: Add UART2 dt node for Exynos3250 SoC Chanwoo Choi
2016-03-15 7:38 ` [PATCH v3 5/8] ARM: dts: Add initial gpio setting of MMC2 device for exynos3250-monk Chanwoo Choi
[not found] ` <1458027490-13787-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-15 7:38 ` [PATCH v3 6/8] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC Chanwoo Choi
2016-03-15 7:38 ` [PATCH v3 7/8] ARM: dts: Add exynos3250-artik5 dtsi file for ARTIK5 module Chanwoo Choi
2016-03-18 21:01 ` Rob Herring
2016-03-19 11:44 ` Chanwoo Choi
2016-03-15 7:38 ` [PATCH v3 8/8] ARM: dts: Add MSHC2 dt node for SD card for exynos3250-artik5-eval board Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F509E6.7080807@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=sw0312.kim@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).