From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers. Date: Mon, 28 Mar 2016 10:02:10 -0500 Message-ID: <56F94772.7070009@lechnology.com> References: <1458863503-31121-1-git-send-email-david@lechnology.com> <1458863503-31121-3-git-send-email-david@lechnology.com> <56F573F3.90500@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56F573F3.90500-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergei Shtylyov Cc: petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org, David.Laight-ZS65k/vG3HxXrIkS9f7CXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Sekhar Nori , Kevin Hilman , Kishon Vijay Abraham I , Greg Kroah-Hartman , Alan Stern , Bin Liu , Lee Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:ARM PORT" , "open list:USB SUBSYSTEM" List-Id: devicetree@vger.kernel.org On 03/25/2016 12:22 PM, Sergei Shtylyov wrote: > On 03/25/2016 02:51 AM, David Lechner wrote: >> +/* register offsets */ >> +#define CFGCHIP_REG(n) (n * 4) >> +#define CFGCHIP0_REG CFGCHIP_REG(0) >> +#define CFGCHIP1_REG CFGCHIP_REG(1) >> +#define CFGCHIP2_REG CFGCHIP_REG(2) >> +#define CFGCHIP3_REG CFGCHIP_REG(3) >> +#define CFGCHIP4_REG CFGCHIP_REG(4) > > Why not just use CFGCHIP_REG(n) directly? I considered that, but I went this way because A) the TRM uses, for example, "CFGCHIP2", so I wanted to keep "CFGCHIP" and "2" together and B) this tells you how many CFGCHIP registers there are, i.e. there is no CFGCHIP5_REG. >> @@ -53,7 +31,6 @@ struct da8xx_ohci_root_hub { >> /* Time from power on to power good (in 2 ms units) */ >> u8 potpgt; >> }; >> - > > Why? Unintentional. Must have sneaked in through rebasing or something. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html