From: Nishanth Menon <nm@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Schuyler Patton" <spatton@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: AM572x-IDK Initial Support
Date: Mon, 28 Mar 2016 11:37:03 -0500 [thread overview]
Message-ID: <56F95DAF.1080901@ti.com> (raw)
In-Reply-To: <20160325150344.GA1268@rob-hp-laptop>
On 03/25/2016 10:03 AM, Rob Herring wrote:
> On Thu, Mar 24, 2016 at 05:30:44PM -0500, Nishanth Menon wrote:
>> From: Schuyler Patton <spatton@ti.com>
[...]
>> +- AM5728 IDK
>> + compatible = "ti,am5728-idk", "ti,am5728", "ti,dra742", "ti,dra74", "ti,dra7"
>
> Okay, but I think the TI folks have gone a bit crazy with all these
> compatible strings...
>
Sadly yes :( too many paper spins and trying to maintain requirements
of exact match than wild cards is starting to look crazier over time :(
>> diff --git a/arch/arm/boot/dts/am572x-idk.dts b/arch/arm/boot/dts/am572x-idk.dts
>> new file mode 100644
>> index 000000000000..bb51f6de7b45
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/am572x-idk.dts
>> @@ -0,0 +1,85 @@
[...]
>> + leds {
>> + compatible = "gpio-leds";
>> + led@0 {
>
> Unit-address without reg is going to start warning in dtc. Use something
> like "cpu0-led" instead.
>
Fixed. Thanks. Updated version posted
https://patchwork.kernel.org/patch/8679861/
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2016-03-28 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 22:30 [PATCH] ARM: dts: AM572x-IDK Initial Support Nishanth Menon
2016-03-25 15:03 ` Rob Herring
2016-03-28 16:37 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F95DAF.1080901@ti.com \
--to=nm@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=spatton@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).