From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH v7 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Date: Wed, 30 Mar 2016 15:34:24 +0800 Message-ID: <56FB8180.5040205@huawei.com> References: <1458830676-27075-1-git-send-email-shannon.zhao@linaro.org> <1458830676-27075-11-git-send-email-shannon.zhao@linaro.org> <56FAAEED.7060108@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56FAAEED.7060108-5wv7dgnIgG8@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julien Grall , Shannon Zhao , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, stefano.stabellini-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org, david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, peter.huangpeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016/3/30 0:35, Julien Grall wrote: > Hi Shannon, > > On 24/03/16 14:44, Shannon Zhao wrote: >> When booting with ACPI, it could get the event-channel irq through > > The kernel will always get the event-channel IRQ through > HVM_PARAM_CALLBACK_IRQ. > > So I would say: ", the kernel will get the event-channel..." > >> HVM_PARAM_CALLBACK_IRQ. >> >> Signed-off-by: Shannon Zhao >> Reviewed-by: Stefano Stabellini >> --- >> arch/arm/xen/enlighten.c | 36 +++++++++++++++++++++++++++++++++++- >> 1 file changed, 35 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c >> index d94f726..680aae0 100644 >> --- a/arch/arm/xen/enlighten.c >> +++ b/arch/arm/xen/enlighten.c >> @@ -30,6 +30,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> @@ -278,6 +279,35 @@ void __init xen_early_init(void) >> add_preferred_console("hvc", 0, NULL); >> } >> >> +static void __init xen_acpi_guest_init(void) >> +{ >> +#ifdef CONFIG_ACPI >> + struct xen_hvm_param a; >> + int interrupt, trigger, polarity; >> + >> + a.domid = DOMID_SELF; >> + a.index = HVM_PARAM_CALLBACK_IRQ; >> + xen_events_irq = 0; >> + >> + if (!HYPERVISOR_hvm_op(HVMOP_get_param, &a)) { >> + if ((a.value >> 56) == HVM_PARAM_CALLBACK_TYPE_PPI) { >> + interrupt = a.value & 0xff; >> + trigger = ((a.value >> 8) & 0x1) ? ACPI_EDGE_SENSITIVE >> + : ACPI_LEVEL_SENSITIVE; >> + polarity = ((a.value >> 8) & 0x2) ? ACPI_ACTIVE_LOW >> + : ACPI_ACTIVE_HIGH; >> + xen_events_irq = acpi_register_gsi(NULL, interrupt, >> + trigger, polarity); >> + } >> + } > > Can you invert the condition to remove one layer of indentation? Sure, will update. Thanks, -- Shannon