From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node Date: Wed, 30 Mar 2016 13:12:52 +0300 Message-ID: <56FBA6A4.2050509@mentor.com> References: <1459290646-3592-1-git-send-email-manabian@gmail.com> <1459290646-3592-3-git-send-email-manabian@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1459290646-3592-3-git-send-email-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joachim Eastwood , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Joachim, On 30.03.2016 01:30, Joachim Eastwood wrote: > Add unit name to memory to remove the following warning: > Warning (unit_address_vs_reg): Node /memory has a reg or ranges > property, but no unit name > > Signed-off-by: Joachim Eastwood > --- > arch/arm/boot/dts/skeleton.dtsi | 2 +- > arch/arm/boot/dts/skeleton64.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi > index b41d241..a20da0a 100644 > --- a/arch/arm/boot/dts/skeleton.dtsi > +++ b/arch/arm/boot/dts/skeleton.dtsi > @@ -9,5 +9,5 @@ > #size-cells = <1>; > chosen { }; > aliases { }; > - memory { device_type = "memory"; reg = <0 0>; }; > + memory@0 { device_type = "memory"; reg = <0 0>; }; > }; > diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi > index b5d7f36..6dbe9f9 100644 > --- a/arch/arm/boot/dts/skeleton64.dtsi > +++ b/arch/arm/boot/dts/skeleton64.dtsi > @@ -9,5 +9,5 @@ > #size-cells = <2>; > chosen { }; > aliases { }; > - memory { device_type = "memory"; reg = <0 0 0 0>; }; > + memory@0 { device_type = "memory"; reg = <0 0 0 0>; }; > }; > this looks wrong, because all inherited compiled dtbs will contain memory@0 device node, for example (with applied 4/7 from this series): % scripts/dtc/dtc -I dtb -O dts arch/arm/boot/dts/lpc4357-ea4357-devkit.dtb | grep -A3 memory@ memory@0 { device_type = "memory"; reg = <0x0 0x0>; }; -- memory@28000000 { device_type = "memory"; reg = <0x28000000 0x2000000>; }; -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html