From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node Date: Wed, 30 Mar 2016 16:06:56 +0300 Message-ID: <56FBCF70.80006@mentor.com> References: <1459290646-3592-1-git-send-email-manabian@gmail.com> <1459290646-3592-3-git-send-email-manabian@gmail.com> <20160330110611.GB25354@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160330110611.GB25354@leverpostej> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland , Joachim Eastwood Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 30.03.2016 14:06, Mark Rutland wrote: > On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote: >> Add unit name to memory to remove the following warning: >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges >> property, but no unit name > > If anything, it would be better to get rid of the memory node from the > skeleton DTs. > > For DTs which have a memory node there's no problem, and DTs which > expect a bootlaoder to fill things in have a logical place to document > that fact. Generally I support this. U-boot still creates or fixes up "/memory" node only, assuming that a bootloader is updated rarely the kernel should continue to process in expected way "/memory" device node, also note that ePAPR says ePAPR> If a system has multiple ranges of memory, multiple memory nodes ePAPR> can be created, or the ranges can be specified in the reg property ePAPR> of a single memory node. Having just a DT on hand it won't be possible to make assumptions about a bootloader, also "/memory" without a given unit address is used by other kernels and a bootloader can respect this. The only problem I see if DTB is updated on a board but a board bootloader on fix-up is capable to fill a preexisting "/memory" device node in only, otherwise it is not clear why the device node is present in skeleton.dtsi. >> Signed-off-by: Joachim Eastwood >> --- >> arch/arm/boot/dts/skeleton.dtsi | 2 +- >> arch/arm/boot/dts/skeleton64.dtsi | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi >> index b41d241..a20da0a 100644 >> --- a/arch/arm/boot/dts/skeleton.dtsi >> +++ b/arch/arm/boot/dts/skeleton.dtsi >> @@ -9,5 +9,5 @@ >> #size-cells = <1>; >> chosen { }; >> aliases { }; >> - memory { device_type = "memory"; reg = <0 0>; }; >> + memory@0 { device_type = "memory"; reg = <0 0>; }; >> }; >> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi >> index b5d7f36..6dbe9f9 100644 >> --- a/arch/arm/boot/dts/skeleton64.dtsi >> +++ b/arch/arm/boot/dts/skeleton64.dtsi >> @@ -9,5 +9,5 @@ >> #size-cells = <2>; >> chosen { }; >> aliases { }; >> - memory { device_type = "memory"; reg = <0 0 0 0>; }; >> + memory@0 { device_type = "memory"; reg = <0 0 0 0>; }; >> }; >> -- >> 2.7.4 >> -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html