From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Ben Hutchings
<ben.hutchings-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: CT kernel
<linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org>
Subject: Re: [RFC PATCH] ARM: dts: DRA74X: Move common pinctrl definitions to common header
Date: Fri, 1 Apr 2016 08:17:30 -0500 [thread overview]
Message-ID: <56FE74EA.3000703@ti.com> (raw)
In-Reply-To: <1459514690.11664.1.camel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
On 04/01/2016 07:44 AM, Ben Hutchings wrote:
> The I2C{1,2}, MCSPI{1,2}, UART{1,2}, QSPI1, USB{1,2}, RGMII
> and ATL functions can each be wired in only one way. Reduce
> duplication by defining that in dra74x.dtsi.
>
> Signed-off-by: Ben Hutchings <ben.hutchings-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> ---
> arch/arm/boot/dts/am57xx-beagle-x15.dts | 50 +---------
> arch/arm/boot/dts/dra7-evm.dts | 142 +-------------------------
> arch/arm/boot/dts/dra74x.dtsi | 171 ++++++++++++++++++++++++++++++++
> 3 files changed, 174 insertions(+), 189 deletions(-)
NAK. Couple of reasons:
A) Based on AM57xx/DRA7 SoC definitions these pin configuration should
actually be deleted since the pinmuxing is only supposed to be done in
u-boot (thanks to IODelay and other glitch constraints documented in TRM).
B) newer packaging plans do take place that will make reuse of
dra74x.dtsi harder by consolidating the pinmux in a central location.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-04-01 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 12:44 [RFC PATCH] ARM: dts: DRA74X: Move common pinctrl definitions to common header Ben Hutchings
[not found] ` <1459514690.11664.1.camel-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2016-04-01 13:17 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE74EA.3000703@ti.com \
--to=nm-l0cymroini0@public.gmane.org \
--cc=ben.hutchings-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).