* [PATCH] ARM: dts: armv7-m: add address to unit name
@ 2016-04-02 6:08 Stefan Agner
2016-04-02 13:41 ` Joachim Eastwood
[not found] ` <1459577299-2818-1-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Agner @ 2016-04-02 6:08 UTC (permalink / raw)
To: arnd
Cc: mcoquelin.stm32, u.kleine-koenig, shawnguo, kernel, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree,
linux-arm-kernel, linux-kernel, Stefan Agner
Add address to unit name to remove the following warning:
Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
reg or ranges property, but no unit name
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Hi Arnd,
Not sure through which tree this should go but an earlier patch
seemd to be applied directly by you...
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: armv7-m: add address to unit name
2016-04-02 6:08 [PATCH] ARM: dts: armv7-m: add address to unit name Stefan Agner
@ 2016-04-02 13:41 ` Joachim Eastwood
[not found] ` <1459577299-2818-1-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Joachim Eastwood @ 2016-04-02 13:41 UTC (permalink / raw)
To: Stefan Agner
Cc: Arnd Bergmann, Maxime Coquelin, Uwe Kleine-König, Shawn Guo,
kernel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, devicetree, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 2 April 2016 at 08:08, Stefan Agner <stefan@agner.ch> wrote:
> Add address to unit name to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
> reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
> arch/arm/boot/dts/armv7-m.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
> #include "skeleton.dtsi"
>
> / {
> - nvic: nv-interrupt-controller {
> + nvic: nv-interrupt-controller@0xe000e100 {
While changing the line it might be good idea to use the standard
'interrupt-controller' name instead.
I posted the same patch couple of days ago, btw.
http://marc.info/?l=devicetree&m=145929088915714&w=2
But I don't care which one that is applied.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <1459577299-2818-1-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>]
* Re: [PATCH] ARM: dts: armv7-m: add address to unit name
[not found] ` <1459577299-2818-1-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
@ 2016-04-02 16:12 ` Sergei Shtylyov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-04-02 16:12 UTC (permalink / raw)
To: Stefan Agner, arnd-r2nGTMty4D4
Cc: mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w, pawel.moll-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hello.
On 4/2/2016 9:08 AM, Stefan Agner wrote:
> Add address to unit name to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
> reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
> arch/arm/boot/dts/armv7-m.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
> #include "skeleton.dtsi"
>
> / {
> - nvic: nv-interrupt-controller {
> + nvic: nv-interrupt-controller@0xe000e100 {
Drop "0x" from <unit address> please. And the name should be just
"interrupt-controller@..."
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-02 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-02 6:08 [PATCH] ARM: dts: armv7-m: add address to unit name Stefan Agner
2016-04-02 13:41 ` Joachim Eastwood
[not found] ` <1459577299-2818-1-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
2016-04-02 16:12 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).