From: Kaustabh Chakraborty <kauschluss@disroot.org>
To: Conor Dooley <conor@kernel.org>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org, denis.ciocca@st.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
robh+dt@kernel.org, kauschluss@disroot.org
Subject: Re: [PATCH v4 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer
Date: Sat, 15 Jun 2024 09:46:59 +0000 [thread overview]
Message-ID: <56ab50d7c542356b7e377023b84a6018@disroot.org> (raw)
In-Reply-To: <20240611-reassign-eliminate-b05e4a302cfb@spud>
On 2024-06-11 18:17, Conor Dooley wrote:
> On Tue, Jun 11, 2024 at 09:35:53PM +0530, Kaustabh Chakraborty wrote:
>> Add compatible for LIS2DS12 accelerometer by STMicroelectronics.
>
> I can see that! Your commit message should mention why this device
> is not compatible with existing variants.
Sure, is adding the WhoAmI value enough? Or do I also have to
explain the different registers and sensor settings.
>
> Thanks,
> Conor.
>
>>
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>> Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
>> index fff7e3d83a02..71c1ee33a393 100644
>> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
>> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
>> @@ -26,6 +26,7 @@ properties:
>> - st,lis2dw12
>> - st,lis2hh12
>> - st,lis2dh12-accel
>> + - st,lis2ds12
>> - st,lis302dl
>> - st,lis331dl-accel
>> - st,lis331dlh-accel
>> --
>> 2.45.1
>>
>>
next prev parent reply other threads:[~2024-06-15 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 16:05 [PATCH v4 1/2] iio: accel: st_accel: add support for LIS2DS12 Kaustabh Chakraborty
2024-06-11 16:05 ` [PATCH v4 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer Kaustabh Chakraborty
2024-06-11 18:17 ` Conor Dooley
2024-06-15 9:46 ` Kaustabh Chakraborty [this message]
2024-06-15 12:11 ` Conor Dooley
2024-06-15 17:56 ` Jonathan Cameron
2024-06-15 13:49 ` Jonathan Cameron
2024-06-18 12:21 ` Kaustabh Chakraborty
2024-06-18 17:38 ` Conor Dooley
2024-06-20 16:42 ` Kaustabh Chakraborty
2024-06-21 14:21 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ab50d7c542356b7e377023b84a6018@disroot.org \
--to=kauschluss@disroot.org \
--cc=conor@kernel.org \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).