From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38530C433F5 for ; Thu, 31 Mar 2022 15:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239232AbiCaPqO (ORCPT ); Thu, 31 Mar 2022 11:46:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239432AbiCaPp5 (ORCPT ); Thu, 31 Mar 2022 11:45:57 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95DBD1E5232; Thu, 31 Mar 2022 08:40:33 -0700 (PDT) X-UUID: ab6246be6d714f2d8d6c7ef929e3e8a3-20220331 X-UUID: ab6246be6d714f2d8d6c7ef929e3e8a3-20220331 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1623740777; Thu, 31 Mar 2022 23:40:04 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 31 Mar 2022 23:40:02 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 31 Mar 2022 23:40:02 +0800 Message-ID: <56ca6920f036b74b28c5858d8b28c3f3046c4758.camel@mediatek.com> Subject: Re: [PATCH v16 4/8] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 From: Jason-JH Lin To: Matthias Brugger , CK Hu , "Rob Herring" , Chun-Kuang Hu , Philipp Zabel , AngeloGioacchino Del Regno CC: Maxime Coquelin , David Airlie , Daniel Vetter , Alexandre Torgue , , , , , Fabien Parent , , , , , , , , Date: Thu, 31 Mar 2022 23:40:02 +0800 In-Reply-To: <01e57ed9-222c-5b74-fe2b-4d22fe802c98@gmail.com> References: <20220307032859.3275-1-jason-jh.lin@mediatek.com> <20220307032859.3275-5-jason-jh.lin@mediatek.com> <97bc1358813a2449d6e62653eb7af9906dfb190e.camel@mediatek.com> <01e57ed9-222c-5b74-fe2b-4d22fe802c98@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Matthias, * Thanks for the reviews. On Thu, 2022-03-31 at 13:01 +0200, Matthias Brugger wrote: > > On 30/03/2022 12:04, Jason-JH Lin wrote: > > Hi CK, > > > > Thanks for the review. > > > > On Mon, 2022-03-28 at 13:39 +0800, CK Hu wrote: > > > Hi, Jason: > > > > > > On Mon, 2022-03-28 at 13:03 +0800, Jason-JH Lin wrote: > > > > Hi CK, > > > > > > > > Thanks for the reviews. > > > > > > > > On Mon, 2022-03-07 at 11:28 +0800, jason-jh.lin wrote: > > > > > Add mt8195 vdosys0 clock driver name and routing table to > > > > > the driver data of mtk-mmsys. > > > > > > > > > > Signed-off-by: jason-jh.lin > > > > > Acked-by: AngeloGioacchino Del Regno < > > > > > angelogioacchino.delregno@collabora.com> > > > > > --- > > > > > Impelmentation patch of vdosys1 can be refered to [1] > > > > > > > > > > [1] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 > > > > > --- > > > > > drivers/soc/mediatek/mt8195-mmsys.h | 130 > > > > > +++++++++++++++++++++++++ > > > > > drivers/soc/mediatek/mtk-mmsys.c | 11 +++ > > > > > include/linux/soc/mediatek/mtk-mmsys.h | 9 ++ > > > > > 3 files changed, 150 insertions(+) > > > > > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h > > > > > > > > > > diff --git a/drivers/soc/mediatek/mt8195-mmsys.h > > > > > b/drivers/soc/mediatek/mt8195-mmsys.h > > > > > new file mode 100644 > > > > > index 000000000000..24a3afe23bc8 > > > > > --- /dev/null > > > > > +++ b/drivers/soc/mediatek/mt8195-mmsys.h > > > > > @@ -0,0 +1,130 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > > > > + > > > > > +#ifndef __SOC_MEDIATEK_MT8195_MMSYS_H > > > > > +#define __SOC_MEDIATEK_MT8195_MMSYS_H > > > > > + > > > > > +#define MT8195_VDO0_OVL_MOUT_EN > > > > > > > > > > 0xf14 > > > > > +#define MT8195_MOUT_DISP_OVL0_TO_DISP_RDMA0 > > > > > BIT(0) > > > > > +#define MT8195_MOUT_DISP_OVL0_TO_DISP_WDMA0 > > > > > BIT(1) > > > > > > > > > > Useless, so remove. > > > > > > > > > > +#define MT8195_MOUT_DISP_OVL0_TO_DISP_OVL1 > > > > > BIT(2) > > > > > Ditto.Useless, so remove. > > > > > Regards, > > > > > CK > > > > > > > > Although these definitions are not used, they represent the > > > > functionality provided by this register. > > > > > > > > I think we can show that we have these capabilities by defining > > > > them. > > > > > > > > Can we keep these definitions? > > > > > > It's better that we know how to use it. Even though the symbol > > > name > > > show some information, but I would like to add it to > > > mmsys_mt8195_routing_table[]. > > > > > > Regards, > > > CK > > > > > > > OK, I think I just remove the useless define. > > Actually I would prefer to add it to the routing table to describe > all the > capabilities of the HW. > > Is there any technical problem with that? > > Regards, > Matthias > OK, I'll add keep these definitions and add them to the routing table. Regards, Jason-JH.Lin > > Thanks. > > > > Regards, > > Jason-JH.Lin > > > > > > > > Regards, > > > > Jason-JH.Lin > > > > > > > > > +#define MT8195_MOUT_DISP_OVL1_TO_DISP_RDMA1 > > > > > BIT(4) > > > > > +#define MT8195_MOUT_DISP_OVL1_TO_DISP_WDMA1 > > > > > BIT(5) > > > > > +#define MT8195_MOUT_DISP_OVL1_TO_DISP_OVL0 > > > > > BIT(6) > > > > > > > > > > > > [snip] > > > > > > > > > > -- Jason-JH Lin