Re: [PATCH] ARM: dts: qcom: add Nokia Lumia 920

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/08/2026 14:50, SuperHacker UEFI wrote:
> From 7580a1d391863c24750dab4900249dcfb9fc1626 Mon Sep 17 00:00:00 2001
> From: UEFI-code <zhuoshizhang@hotmail.com>
> Date: Wed, 5 Aug 2026 20:32:40 +0900
> Subject: [PATCH] ARM: dts: qcom: add Nokia Lumia 920
> 
> Add basic Device Tree support for the Nokia Lumia 920.
> 
> Currently tested:
> - eMMC
> - EFI GOP framebuffer
> - initramfs boot
> 
> USB has partial functionality and other peripherals
> remain untested.
> 
> Signed-off-by: UEFI-code <zhuoshizhang@hotmail.com>

Please read submitting patches, we do not take anonymous code.

> ---
>  .../devicetree/bindings/arm/qcom.yaml         |   1 +
>  arch/arm/boot/dts/qcom/Makefile               |   1 +
>  .../boot/dts/qcom/qcom-msm8960-lumia-920.dts  | 361 ++++++++++++++++++


Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

>  3 files changed, 363 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8960-lumia-920.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index adbfaea32..31532fbbe 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -204,6 +204,7 @@ properties:
>            - enum:
>                - qcom,msm8960-cdp
>                - samsung,expressatt
> +              - lumia,920
>            - const: qcom,msm8960
>  
>        - items:
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 3dfb1c8ce..9a7fa44a8 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -31,6 +31,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-msm8916-samsung-serranove.dtb \
>  	qcom-msm8960-cdp.dtb \
>  	qcom-msm8960-samsung-expressatt.dtb \
> +	qcom-msm8960-lumia-920.dtb \
>  	qcom-msm8974-lge-nexus5-hammerhead.dtb \
>  	qcom-msm8974-sony-xperia-rhine-amami.dtb \
>  	qcom-msm8974-sony-xperia-rhine-honami.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-lumia-920.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-lumia-920.dts
> new file mode 100644
> index 000000000..a5c8d1a5f
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-lumia-920.dts
> @@ -0,0 +1,361 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <dt-bindings/input/input.h>
> +
> +#include "qcom-msm8960.dtsi"
> +
> +/ {
> +	model = "Nokia Lumia 920";
> +	compatible = "nokia,lumia920", "qcom,msm8960";
> +};
> +
> +&soc {
> +    qfprom: qfprom@700000 {
> +        compatible = "qcom,msm8960-qfprom", "qcom,qfprom";
> +        reg = <0x00700000 0x1000>;
> +
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;
> +
> +        tsens_calib: calib@404 {
> +            reg = <0x404 0x10>;
> +        };
> +
> +        tsens_backup: backup_calib@414 {
> +            reg = <0x414 0x10>;
> +        };
> +    };
> +};
> +
> +&gcc {
> +    compatible = "qcom,gcc-msm8960", "syscon";

Why are you overriding SoC nodes in a board DTS?

...


> +
> +/* eMMC */
> +&sdcc1 {
> +	status = "okay";
> +};
> +
> +// usb1

Useless comment, but anyway decide about style of comments.

> +&usb1 {
> +    status = "okay";
> +};
> +
> +&usb_hs1_phy {
> +	v3p3-supply = <&pm8921_l3>;
> +	v1p8-supply = <&pm8921_l4>;
> +};
> \ No newline at end of file

You have clearly visible patch warnings.

Best regards,
Krzysztof