From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C253AA1B2; Tue, 28 Apr 2026 07:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360225; cv=none; b=SNniDVVM1T2iTDUJ2zmPgEHxkPLtbMn3dYwQaCVgefOguHTkwNXzD5sMcqb0iVBWNrtxZzmZIsRV56MOfoPICVIAJvVU6oHwMaYcEVrkb2+7K1w5ZVwm+ThA2IjFP1/G5SMkktGAXtLj6PKJnukSx8JEOMBg6W67sbop23bUvgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360225; c=relaxed/simple; bh=TtoGexmgAiwUbNPhRjJiMmOOiVKbBVpRUGsDRKUVH1E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GhbrN+sWKedPQqzKydAGBsp+kNC9dud3mnoANrlfiG2XtQcwnooHcJibBoVEuxKgYC/JvhCxvmyFZ04Mhy+3KGTwhkKFA6y09gXkHXNYkMngYXZ217+b/e2WsGbtQN7Rxj97uv+lQCNON5F80hrl9YurLJrrvm6aZ4rxq2HldLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f69C224W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f69C224W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0DC1C2BCB6; Tue, 28 Apr 2026 07:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777360225; bh=TtoGexmgAiwUbNPhRjJiMmOOiVKbBVpRUGsDRKUVH1E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=f69C224W4LOKHE7t55Ksp7Y4hpBRp4cwPKqPzt36knA3cZSUAvfi68GFPbkB1CGEX 6aa2XgD+oJibpT7osVJpLOOk37Nbb1n6GPP9T0l1msAru9Cq9Cj0oYXa3sJ1xoPdsT +Q93i1A6O19kKyMYZAzoUoCj+caJoziwZCa4URV3c8sDR7mLt6FdOcDy/c/hP4VDCY 806r2K/gx90h6M9XXqAJetRHC0MuqKLE87pHthvigZw+nLBDPhMGipmjojt1nL/RGb ioRPYcP3lisDoBpM0bkUAKrJwa9NFYUcDiaPXvdbn6emeRMtfidwvhGBInd3Y4XEgY x6oQ2iPBpXXxQ== Message-ID: <56d609dd-62be-47eb-8ba3-c5d70d773113@kernel.org> Date: Tue, 28 Apr 2026 08:10:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 04/11] arm64: dts: qcom: msm8939: Add venus node To: Erikas Bitovtas , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260427-msm8939-venus-rfc-v3-0-288195bb7917@gmail.com> <20260427-msm8939-venus-rfc-v3-4-288195bb7917@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260427-msm8939-venus-rfc-v3-4-288195bb7917@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/04/2026 18:58, Erikas Bitovtas wrote: > + video-decoder { > + compatible = "venus-decoder"; > + clocks = <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>, > + <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>; > + clock-names = "core0", "core1"; > + power-domains = <&gcc VENUS_CORE0_GDSC>, > + <&gcc VENUS_CORE1_GDSC>; > + power-domain-names = "core0", "core1"; > + }; > + > + video-encoder { > + compatible = "venus-encoder"; > + clocks = <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>, > + <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>; > + clock-names = "core0", "core1"; > + power-domains = <&gcc VENUS_CORE0_GDSC>, > + <&gcc VENUS_CORE1_GDSC>; > + power-domain-names = "core0", "core1"; > + }; So to be fair in this case you do have a reason to have an encoder and decoder compatible here _but_ it should be the case that one one of the sub-devices contains CORE0 related stuff and the other CORE1 related stuff. Because in that case the sub-devices actually represent individual hardware settings. So listing power-domains and clocks for both cores in each node like this militates against that. The other thing is to double check of the encoder and decoder are inter-changable here i.e. can either core be encoder or decoder or is it fixed ? I believe on older generations - perhaps not on 8939 it is not interchangable. If it is interchangable then declaring either node specifically encoder or decoder is incorrect so you should declare that inline in venus itself. Perhaps Vikash or Dikshita could confirm whether or not the cores have fixed encoder/decoder functionality. TBH I think you should stick to the inline declaration. --- bod