From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 863FAC636D6 for ; Mon, 6 Feb 2023 12:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbjBFMhC (ORCPT ); Mon, 6 Feb 2023 07:37:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbjBFMhB (ORCPT ); Mon, 6 Feb 2023 07:37:01 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F8ED20070 for ; Mon, 6 Feb 2023 04:36:59 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id l21-20020a05600c1d1500b003dfe462b7e4so4631115wms.0 for ; Mon, 06 Feb 2023 04:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=e1/W4vRspGFqPKyfZ9iLWstpJUiKCT/PotldFbMIbXE=; b=YpnQj+Qewd739lMDk8Qj0AGFdVsu+mcPOF7zxKNf5Mu0W1wJpDEhdV70krq140dGs8 xQAEq02J6OJvKh1zfvqxZCcstAdsb2OS+mwZTj9gjpQ0OBY8+j+7Bz3fjnw7vj7iCc3K sSv1ESPOhOTx1A4ixr3Mj3GvfYbJTiiSXv+STuEfl5qfC1D792LBeleX+IsdT5A+WarZ rMviQdHyMMd58wSkcdRXurpJVAwF4HUu3+s+X+hC8so7QFqHaISxIUxw/HEsUA43BEqE h33LFR+MtNGlHwoEJhanuEP+2jy1LhiO/8St7QXD3TrppBL+vz2AYtUZguhrDKkL1ovn JAYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e1/W4vRspGFqPKyfZ9iLWstpJUiKCT/PotldFbMIbXE=; b=flLDE1HnIAc8i3BONtQg5zeFj0ggU4Is2khMm3ASq1ekRzQpkvKy6LMDKJ/71hWeiZ Z6QUmPYbwzbf9u5K5cl3cp3Mlso9prKtUjVPVRhEWJvk8kBa5D9EKpNEq5sNm2uZ4UQT uLCrP7Cpo/KVyI7OR0aSghiBy64NS8b/E0uMvIJ4jhD0N9oK9Pyj9kmRlueTFArdxjTm eB2RPGfCe4GOSyW5RfeG6FXLzhjvd/JFKb/PGP0GB3Nhktm9ZxxprvfssYEmbXii3MiY sZc2Rydxin3q0WufiufWc+YJ+CI8Xpc/AZK/9HW47slZdm63Ec+D+BGB4ZuUlIE7g5Oq hRPw== X-Gm-Message-State: AO0yUKUaQbxonkhO+pW4KWSzIdNT1/l0Zs+vJkyNGgczUif5r1Nyc71d 4AHJPozmUIenxHozjxjUub9mOQ== X-Google-Smtp-Source: AK7set9fB0Ww3UvqTSLoPFgsNKMOmP1EKVTidKJRXRsxAwbBRtkjfrHPrMf9DpUSFF3AM0gXH+e+TQ== X-Received: by 2002:a05:600c:1e89:b0:3dc:5b48:ee5 with SMTP id be9-20020a05600c1e8900b003dc5b480ee5mr19017077wmb.2.1675687017918; Mon, 06 Feb 2023 04:36:57 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:f03f:3ced:a369:d884? ([2a01:e0a:982:cbb0:f03f:3ced:a369:d884]) by smtp.gmail.com with ESMTPSA id bj24-20020a0560001e1800b002bded7da2b8sm8864067wrb.102.2023.02.06.04.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 04:36:57 -0800 (PST) Message-ID: <56e3816e-c317-1772-1ef3-aeaa9ef0c890@linaro.org> Date: Mon, 6 Feb 2023 13:36:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible Content-Language: en-US To: Dmitry Baryshkov , Krzysztof Kozlowski , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Kuogee Hsieh , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230206-topic-sm8450-upstream-dp-controller-v1-0-f1345872ed19@linaro.org> <20230206-topic-sm8450-upstream-dp-controller-v1-1-f1345872ed19@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/02/2023 12:20, Dmitry Baryshkov wrote: > On 06/02/2023 12:33, Krzysztof Kozlowski wrote: >> On 06/02/2023 11:17, Neil Armstrong wrote: >>> The SM8450 & SM350 shares the same DT TX IP version, use the >>> SM8350 compatible as fallback for SM8450. >>> >>> Signed-off-by: Neil Armstrong >>> --- >>>   Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ >>>   1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> index 0e8d8df686dc..98bae326e655 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> @@ -25,6 +25,10 @@ properties: >>>         - qcom,sc8280xp-edp >>>         - qcom,sdm845-dp >>>         - qcom,sm8350-dp >>> +      - items: >>> +          - enum: >>> +            - qcom,sm8450-dp >> >> Indentation looks wrong here. Testing should fail, did you test it? > > Moreover it also breaks dt-schema, see https://github.com/devicetree-org/dt-schema/issues/98 Yep the change totally broke on rebase, will fix it Sorry for the noise. Neil > >> >> Best regards, >> Krzysztof >> >