From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joshua Clayton <stillcompiling@gmail.com>
Subject: Re: [PATCH v8 3/3] ARM: dts: imx6q-evi: support cyclone-ps-spi
Date: Mon, 23 Jan 2017 16:38:39 -0800
Message-ID: <56ebc91c-18e3-5d55-b8e3-af45ac182a97@gmail.com>
References: <cover.1485211400.git.stillcompiling@gmail.com>
 <c429cec34a880c0d5438091f436a5946a4db3fc0.1485211400.git.stillcompiling@gmail.com>
 <CAOMZO5AmQhjGOa2NaFn0Az4Xnza8jmK=9gpPJpnkmAvN_zxzeA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAOMZO5AmQhjGOa2NaFn0Az4Xnza8jmK=9gpPJpnkmAvN_zxzeA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Fabio Estevam <festevam@gmail.com>
Cc: Alan Tull <atull@opensource.altera.com>, Moritz Fischer <moritz.fischer@ettus.com>, Russell King <linux@armlinux.org.uk>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <kernel@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>, Anatolij Gustschin <agust@denx.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-fpga@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On 01/23/2017 04:00 PM, Fabio Estevam wrote:
> On Mon, Jan 23, 2017 at 8:51 PM, Joshua Clayton
> <stillcompiling@gmail.com> wrote:
>> Add support for Altera cyclone V FPGA connected to an spi port
>> to the evi devicetree file
>>
>> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
>> ---
>>  arch/arm/boot/dts/imx6q-evi.dts | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts
>> index 24fe093..a0cbb2d 100644
>> --- a/arch/arm/boot/dts/imx6q-evi.dts
>> +++ b/arch/arm/boot/dts/imx6q-evi.dts
>> @@ -82,6 +82,15 @@
>>         pinctrl-names = "default";
>>         pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>;
>>         status = "okay";
>> +
>> +       fpga_spi: cyclonespi@0 {
>> +               compatible = "altr,fpga-passive-serial";
>> +               spi-max-frequency = <20000000>;
>> +               reg = <0>;
>> +               pinctrl-0 = <&pinctrl_fpgaspi>;
>> +               nconfig-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
>> +               nstat-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
> Your binding doc says that 'confd-gpios ' is a required property, but
> you did not put it here.
>
> Either it is missing here or you should mention that it is optional in
> the binding doc.
You're right, Fabio.
The barebox driver from which I stole the binding had a confd and no nstat.
I've got an nstat and no confd.
One or the other is needed to know whether the bitstream was loaded.

I can add support for using the confd, but with no way to test it, I forebear.

I guess they should both be optional and a note placed that this driver
currently uses only the nstat.

Will change the doc to reflect that.