From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F03C001DE for ; Mon, 17 Jul 2023 06:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbjGQGNh (ORCPT ); Mon, 17 Jul 2023 02:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231154AbjGQGNg (ORCPT ); Mon, 17 Jul 2023 02:13:36 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E17BE1B0 for ; Sun, 16 Jul 2023 23:13:34 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-986d8332f50so545843266b.0 for ; Sun, 16 Jul 2023 23:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689574413; x=1692166413; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KX0bayVx0aeOD1sEoQkoLYBCqaL+9BObNzNA02HtFVo=; b=T+XSj60tDa3Nd+x7EwbocVcliq3Lu2S15NHeUomZ+yOmpYLshhLT35Esp8SnFNFZWs sN4qkGWiPFNHwwh7fBmhN/acOwzB4IOCfR2FpaoJqBRHUMWaUMbLgQu4X1zNjqjkNDSm 1WBWZSoG7pJy20ea1i4KbPDg7SphFiYAUc3kpgc4TVo4wJh45bn6RVEzlat8GKR42FZi /MX1ydKxzCUlbsaVvuqf7b6DjoBa1Pjf0ASGOewaP2o6Cq/TgqHNwHQKeuH9QgAw8J5S jOSstcIxJ7Ab8Z1WFKMhhkxoDdbRJCZ3htPoLb54qvZgkKicya40j8jhhAc36sBCnnpX C6mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689574413; x=1692166413; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KX0bayVx0aeOD1sEoQkoLYBCqaL+9BObNzNA02HtFVo=; b=F3/kQGQ1ifxHA2vaHiJpy/NRrlsrXrSI6L9ufBJBZ60RB46pMNToM2QbdhHQQzr4r0 YmazkBOVsviVrP8iLehgVReLywk9IzLWd5gbPzhm4Tv1bcgB4TzUId4YH/yVW7Wt9kLN +lTqAosbom1LgvO2WpHhergWi1rpYTg4f76c7yAsCCsOfch/PDJ2kZ6/rImOq8C7HNjQ ZpmqkjTYC0PJMd6Iof0zkPnd+414EU55g4r0MCA98Zo8ME+jIaH2oaTueBQ30WKkv/NV TCCPRs5JtZdM6+U+x2iSaVlwZ9wRz7myP9JXhTz8PCAG5KJEZ7OrsSE6gFLkZJaqpSSv jI3A== X-Gm-Message-State: ABy/qLYVKNUFRslK6VET95Q6FGATKSDX8XAOc2x/VA/O16dMIOfC/B36 j1nzZLTwkWLxHhkAbuFnZL5cLA== X-Google-Smtp-Source: APBJJlG2+ItcbLEp/WFP4gmznNva/Yv4GGL2r7IBi57RTQLW7OnHdrD0NsDzgE1TxvbQjalRJ1Ppnw== X-Received: by 2002:a17:907:9541:b0:978:b94e:83dd with SMTP id ex1-20020a170907954100b00978b94e83ddmr8557820ejc.75.1689574413250; Sun, 16 Jul 2023 23:13:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id n11-20020a1709061d0b00b00982cfe1fe5dsm8744799ejh.65.2023.07.16.23.13.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 23:13:32 -0700 (PDT) Message-ID: <57015d8a-a65a-dd2f-3260-3f78b32db884@linaro.org> Date: Mon, 17 Jul 2023 08:13:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET Content-Language: en-US To: huaqian.li@siemens.com, wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: huaqianlee@gmail.com, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jan.kiszka@siemens.com, baocheng.su@siemens.com, Conor Dooley , Rob Herring References: <20230717040723.1306374-1-huaqian.li@siemens.com> <20230717040723.1306374-2-huaqian.li@siemens.com> From: Krzysztof Kozlowski In-Reply-To: <20230717040723.1306374-2-huaqian.li@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/07/2023 06:07, huaqian.li@siemens.com wrote: > From: Li Hua Qian > > TI RTI (Real Time Interrupt) Watchdog doesn't support to record the > watchdog cause. Add a reserved memory to know the last reboot was caused > by the watchdog card. In the reserved memory, some specific info will be > saved to indicate whether the watchdog reset was triggered in last > boot. > > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Conor Dooley > Reviewed-by: Rob Herring What? Where did these happened? Please provide links. > Signed-off-by: Li Hua Qian > --- > .../bindings/watchdog/ti,rti-wdt.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > index fc553211e42d..4b66c4fcdf35 100644 > --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > @@ -34,6 +34,20 @@ properties: > power-domains: > maxItems: 1 > > + memory-region: > + maxItems: 1 > + description: > + Contains the watchdog reserved memory. It is optional. > + In the reserved memory, the specified values, which are > + PON_REASON_SOF_NUM(0xBBBBCCCC), PON_REASON_MAGIC_NUM(0xDDDDDDDD), > + and PON_REASON_EOF_NUM(0xCCCCBBBB), are pre-stored at the first > + 3 * 4 bytes to tell that last boot was caused by watchdog reset. > + Once the PON reason is captured by driver(rti_wdt.c), the driver > + is supposed to wipe the whole memory region. Surely, if this > + property is set, at least 12 bytes reserved memory starting from > + specific memory address(0xa220000) should be set. More please > + refer to Example 2. > + > required: > - compatible > - reg > @@ -59,3 +73,30 @@ examples: > assigned-clocks = <&k3_clks 252 1>; > assigned-clock-parents = <&k3_clks 252 5>; > }; > + > + - | > + // Example 2 (Add reserved memory for watchdog reset cause): > + /* > + * RTI WDT in main domain on J721e SoC. Assigned clocks are used to > + * select the source clock for the watchdog, forcing it to tick with > + * a 32kHz clock in this case. Add a reserved memory to keep the > + * watchdog reset cause persistent, which was be written in 12 bytes > + * starting from 0xa2200000 by RTI Watchdog Firmware. > + * > + * Reserved memory should be defined as follows: > + * reserved-memory { > + * wdt_reset_memory_region: wdt-memory@a2200000 { > + * reg = <0x00 0xa2200000 0x00 0x1000>; > + * no-map; > + * }; > + * } > + */ Integrate it with existing binding... there is really no need for new example for one new property. Best regards, Krzysztof