From: Markus Elfring <Markus.Elfring@web.de>
To: "André Apitzsch" <git@apitzsch.eu>,
linux-leds@vger.kernel.org, phone-devel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Bjorn Andersson" <andersson@kernel.org>,
"Christophe Jaillet" <christophe.jaillet@wanadoo.fr>,
"Conor Dooley" <conor+dt@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Kees Cook" <kees@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Trilok Soni" <quic_tsoni@quicinc.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] leds: sy7802: Add support for Silergy SY7802 flash LED controller
Date: Sun, 16 Jun 2024 20:55:41 +0200 [thread overview]
Message-ID: <5701d3e7-f67b-4189-a5fd-8a992b9155fb@web.de> (raw)
In-Reply-To: <20240616-sy7802-v4-2-789994180e05@apitzsch.eu>
> The SY7802 is a current-regulated charge pump which can regulate two
> current levels for Flash and Torch modes.
>
> It is a high-current synchronous boost converter with 2-channel high
> side current sources. Each channel is able to deliver 900mA current.
Would you like to improve such a change description with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94
…
> +++ b/drivers/leds/flash/leds-sy7802.c
> @@ -0,0 +1,542 @@
…
> +static int sy7802_strobe_get(struct led_classdev_flash *fl_cdev, bool *state)
> +{
…
> + mutex_lock(&chip->mutex);
> + *state = !!(chip->fled_strobe_used & BIT(led->led_id));
> + mutex_unlock(&chip->mutex);
> +
> + return 0;
> +}
…
Would you become interested to apply a statement like “guard(mutex)(&chip->mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-06-16 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 18:22 [PATCH v4 0/3] Add sy7802 flash led driver André Apitzsch via B4 Relay
2024-06-16 18:22 ` [PATCH v4 1/3] dt-bindings: leds: Add Silergy SY7802 flash LED André Apitzsch via B4 Relay
2024-06-16 18:22 ` [PATCH v4 2/3] leds: sy7802: Add support for Silergy SY7802 flash LED controller André Apitzsch via B4 Relay
2024-06-16 18:55 ` Markus Elfring [this message]
2024-06-17 9:53 ` Pavel Machek
2024-06-17 10:18 ` [v4 " Markus Elfring
2024-06-17 10:59 ` Dmitry Baryshkov
2024-06-17 11:34 ` Markus Elfring
2024-06-21 10:26 ` [PATCH v4 " Lee Jones
2024-06-22 11:55 ` André Apitzsch
2024-06-24 11:14 ` Lee Jones
2024-06-16 18:22 ` [PATCH v4 3/3] arm64: dts: qcom: msm8939-longcheer-l9100: Add rear flash André Apitzsch via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5701d3e7-f67b-4189-a5fd-8a992b9155fb@web.de \
--to=markus.elfring@web.de \
--cc=andersson@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=quic_tsoni@quicinc.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).