From: Kefeng Wang <wangkefeng.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Herbert Xu
<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 1/2] dt/bindings: Add bindings for hisilicon random number generator
Date: Tue, 5 Apr 2016 09:16:58 +0800 [thread overview]
Message-ID: <5703120A.6040803@huawei.com> (raw)
In-Reply-To: <20160404051549.GF17806@rob-hp-laptop>
On 2016/4/4 13:15, Rob Herring wrote:
> On Fri, Apr 01, 2016 at 09:37:43AM +0800, Kefeng Wang wrote:
>> Document the devicetree bindings for the random number generator
>> found on Hisilicon Hip04 and Hip05 soc.
[...]
>> +
>> +Required properties:
>> +- compatible : Should be "hisilicon,hisi-rng"
>
> hisi is a bit redundant with hisilicon and please define SoC specific
> compatible strings.
Due to it exists in both Hip04/Hip05 soc(and maybe some other chips),
how about drop hisi-, just "hisilicon,rng".
Thanks
>
>> +- reg : Offset and length of the register set of this block
>> +
>> +Example:
>> +
>> +rng@d1010000 {
>> + compatible = "hisilicon,hisi-rng";
>> + reg = <0xd1010000 0x100>;
>> +};
>> --
>> 1.7.12.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-04-05 1:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 1:37 [PATCH 1/2] dt/bindings: Add bindings for hisilicon random number generator Kefeng Wang
2016-04-01 1:37 ` [PATCH 2/2] hwrng: hisi: Add support for Hisilicon RNG support Kefeng Wang
2016-04-04 5:15 ` [PATCH 1/2] dt/bindings: Add bindings for hisilicon random number generator Rob Herring
2016-04-05 1:16 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703120A.6040803@huawei.com \
--to=wangkefeng.wang-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).