From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [v14, 01/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Date: Tue, 5 Apr 2016 10:15:24 +0800 Message-ID: <57031FBC.5000904@rock-chips.com> References: <1455534576-1486-1-git-send-email-ykk@rock-chips.com> <20160330203204.GA24156@roeck-us.net> <20160331095600.GD26032@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Doug Anderson , Thierry Reding Cc: Krzysztof Kozlowski , Heiko Stuebner , Seung-Woo Kim , Daniel Kurtz , Andrzej Hajda , Gustavo Padovan , linux-samsung-soc , Russell King , Joonyoung Shim , "open list:ARM/Rockchip SoC..." , Kishon Vijay Abraham I , Javier Martinez Canillas , Kukjin Kim , Rob Herring , Guenter Roeck , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul List-Id: devicetree@vger.kernel.org On 04/01/2016 12:02 AM, Doug Anderson wrote: > Hi, > > On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding wrote: >> Ugh... most of these functions shouldn't be there in the first place. We >> have helpers in the core that already do this. Most of the functionality >> is duplicated in this driver. >> >> I realize that this is a problem that existed in the Exynos DP driver, >> but somebody really ought to rewrite those parts to make use of the DRM >> DP helpers. > As I understand it from discussions in > and > , we > shouldn't block merging the series but someone should pick up this > work after the merge. > > So probably Yakir should fixup the problem pointed out by Guenter and > send a new pull. Yep, should I just update the pull request. Or I should send v15 first and then update the pull request ? - Yakir > -Doug > > >