From: Michael Hennerich <michael.hennerich@analog.com>
To: Jonathan Cameron <jic23@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "Alexandre Courbot" <gnurou@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Paul Cercueil" <paul.cercueil@analog.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Paweł Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v5] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs
Date: Tue, 5 Apr 2016 09:21:13 +0200 [thread overview]
Message-ID: <57036769.4070102@analog.com> (raw)
In-Reply-To: <5700E4E8.40304@kernel.org>
On 04/03/2016 11:39 AM, Jonathan Cameron wrote:
> On 31/03/16 09:01, Linus Walleij wrote:
>> On Wed, Mar 23, 2016 at 9:19 AM, <michael.hennerich@analog.com> wrote:
>>
>>> From: Paul Cercueil <paul.cercueil@analog.com>
>>>
>>> This patch adds support for the AD5592R (spi) and AD5593R (i2c)
>>> ADC/DAC/GPIO devices.
>>>
>>> Signed-off-by: Paul Cercueil <paul.cercueil@analog.com>
>>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>>
>> For this v5 version:
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> I'm fine with this new gpiochip driver being merged into the
>> IIO tree.
>>
> Cool, Paul / Michael,
>
> I still had a few trivial outstanding comments. Please remember to add
> this reviewed-by to V6.
Hi Jonathan,
Sorry I missed these -
With the comment added to the CH_MODE_DAC_AND_ADC description in the
bindings. Do you think we need another ACK from Rob?
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
next prev parent reply other threads:[~2016-04-05 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 8:19 [PATCH v5] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs michael.hennerich
2016-03-23 15:15 ` Rob Herring
2016-03-28 14:30 ` Jonathan Cameron
[not found] ` <56F94019.4040103-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-28 15:08 ` Jonathan Cameron
2016-04-05 7:16 ` Michael Hennerich
[not found] ` <1458721195-28915-1-git-send-email-michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2016-03-31 8:01 ` Linus Walleij
2016-04-03 9:39 ` Jonathan Cameron
2016-04-05 7:21 ` Michael Hennerich [this message]
[not found] ` <57036769.4070102-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2016-04-05 13:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57036769.4070102@analog.com \
--to=michael.hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.cercueil@analog.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).